1433423 - Library Back button takes time to go back with lots of bookmarks

Status: NEW

(Firefox :: Bookmarks & History, enhancement, P5)

Description

[In]

Back button takes time to go back(in library)sometime even hangs the program

Comment 1

[Mark Banner (:standard8)]

Please can you include more information:

- Which operating system you are using?
- Which Firefox version you are using?
- Has this regressed recently, if so when, or has it always been like this?
- How many bookmarks you have total? (You can get this from Help -> Troubleshooting Information -> Places Database -> Verify Integrity).
- Is it slow to go back sometimes, all the time, or just in specific cases? e.g. slow going back to a specific folder or queries, or any folder.
- How long does it take to go back when it is bad?
- How many bookmarks are in the folder/query that you are going back to?

Comment 2

[In]

OS: Windows 7 Pro SP1 32bit
Firefox Version: 58.0
it has always been like this.

+ Initial database size is 10240 KiB
+ Final database size is 10240 KiB
+ Database size is 10240 KiB
+ pragma_user_version is 41
+ pragma_page_size is 32768
+ pragma_synchronous is 1
+ History can store a maximum of 99653 unique pages
+ Table moz_places has 12277 records
+ Table moz_historyvisits has 9 records
+ Table moz_inputhistory has 38 records
+ Table moz_hosts has 2331 records
+ Table moz_bookmarks has 14835 records
+ Table moz_bookmarks_deleted has 0 records
+ Table moz_anno_attributes has 10 records
+ Table moz_annos has 1362 records
+ Table moz_items_annos has 2150 records

Its always slow
It takes 14secs

Comment 3

[Marco Bonardo [:mak]]

you have a lot of bookmarks, likely most of them are in a single folder and that causes slow ops, splitting them a little bit may help.

Did you create those manually in years, or through some add-on?

Comment 4

[In]

(In reply to Marco Bonardo [::mak] from comment #3)
> you have a lot of bookmarks, likely most of them are in a single folder and
> that causes slow ops, splitting them a little bit may help.
> 
> Did you create those manually in years, or through some add-on?

Manually

Comment 5

[In]

(In reply to Mark Banner (:standard8) from comment #1)
> Please can you include more information:
> 
> - Which operating system you are using?
> - Which Firefox version you are using?
> - Has this regressed recently, if so when, or has it always been like this?
> - How many bookmarks you have total? (You can get this from Help ->
> Troubleshooting Information -> Places Database -> Verify Integrity).
> - Is it slow to go back sometimes, all the time, or just in specific cases?
> e.g. slow going back to a specific folder or queries, or any folder.
> - How long does it take to go back when it is bad?
> - How many bookmarks are in the folder/query that you are going back to?

why it says " + Database cleaned up "

Comment 6

[In]

(In reply to Mark Banner (:standard8) from comment #1)
> - How many bookmarks you have total? (You can get this from Help ->
> Troubleshooting Information -> Places Database -> Verify Integrity).

What does this button do

Comment 7

[In]

(In reply to Marco Bonardo [::mak] from comment #3)
> you have a lot of bookmarks, likely most of them are in a single folder and
No they are well organized into folder/sub folders

Comment 8

[Mark Banner (:standard8)]

(In reply to In from comment #6)
> (In reply to Mark Banner (:standard8) from comment #1)
> > - How many bookmarks you have total? (You can get this from Help ->
> > Troubleshooting Information -> Places Database -> Verify Integrity).
> 
> What does this button do

Primarily, it checks the integrity of the database. As part that however, it'll also expire any old records (history records I think), and reduce the size of the database by removing old items from disk. The integrity check is something that Firefox will do regularly anyway.

Comment 9

[In]

(In reply to Mark Banner (:standard8) from comment #8)
> it'll also expire any old records (history records I think), and reduce the
> size of the database by removing old items from disk. 

why it says " + Database cleaned up "

> "it'll also expire any old records (history records I think), and reduce the size of the database by removing old items from disk"

Doing that you made me delete my bookmarks??

Comment 10

[Mark Banner (:standard8)]

(In reply to In from comment #9)
> > "it'll also expire any old records (history records I think), and reduce the size of the database by removing old items from disk"
> 
> Doing that you made me delete my bookmarks??

No.

To save on disk reading and writing, the database may keep deleted data around for a while, as a result, your database file may be slightly bigger than it needs to be. At regular intervals, or when you select the verify button, it will check the database and rewrite it to remove only the redundant data from the disk.

Comment 11

[In]

(In reply to Mark Banner (:standard8) from comment #10)
> rewrite it to remove only the redundant data from the disk.
Does database only contain bookmarks or something else also.
What does redundant mean there?
Why bookmarks will be redundant?
And I am not trolling you sir.

Comment 12

[Mark Banner (:standard8)]

(In reply to In from comment #11)
> (In reply to Mark Banner (:standard8) from comment #10)
> > rewrite it to remove only the redundant data from the disk.
> Does database only contain bookmarks or something else also.

Sorry, I've already described this the best I can in comment 11, and we're way off topic here now. It is a standard programming practice, the only thing that matters with respect to this bug is that it succeeds. It won't remove any of your data.

Comment 13

[In]

(In reply to Mark Banner (:standard8) from comment #12)
How do I mark all our conversion irrelevant to this bug as irrelevant?

Comment 14

[In]

(In reply to Marco Bonardo [::mak] from comment #3)
What line tells number of bookmarks?

Comment 15

[Lina Butler [:lina]]

(In reply to In from comment #14)
> What line tells number of bookmarks?

You should see a line like this in the output:

> + Table moz_bookmarks has 3502 records