143344 - Download progress meter is left-to-right when UI is right-to-left

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect)

Description

[Simon Montagu :smontagu]

Description: when the interface is aligned to the right, e.g. when using a RTL
language (like hebrew or arabic), the progress meter in the download manager
should move from right to left.

Steps to reproduce:
1. aligning the interface to the right: add these lines to the file intl.css, in
the locale\en-US\global, in the en-US.jar file (the language pack file, in the
chrome folder):

window,dialog,wizard,page {
  direction: rtl;
}

menu { direction: rtl; }

tree { direction: rtl; }

2. Download a file in Mozilla
3. Watch the progress meter in the download manager.

Actual results: the bar moves from left to right.
Expected results: the bar should move from right to left.

The progress meter in the status bar doesn't have this problem, btw.

Comment 1

[Jan Varga [:janv]]

-> me

Comment 2

[Jan Varga [:janv]]

hmm, this probably makes our product unusable for some users.
Nominating for buffy.

Comment 3

[Samir Gehani]

Nav triage team: nsbeta1-

Comment 4

[Tsahi Asher]

i could not reproduce this on my hebrew-localised mozilla 1.0.0. for me, the
progress bar moves from right to left correctly.

Comment 5

[Jan Varga [:janv]]

I tried current mozilla trunk and 1.0 build and I still see progress meter to
move from left to right.

I have this in my userChrome.css file:
tree {
  direction: rtl;
}

Are you sure you checked progress meter in download manager ?
It's not opened by default in 1.0 build.

Comment 6

[Tsahi Asher]

i saw it in the dialog that opens when you download a file, the one that shows
you the file name, size, elapsed time and time left. isn't that the download
manager?

did you have the dialoge in RTL? try adding the other lines Simon wrote here:

window,dialog,wizard,page {
  direction: rtl;
}

menu { direction: rtl; }

(although you know better than me what they mean).

Comment 7

[Jan Varga [:janv]]

Do you mean Tools -> Download manager ?

Comment 8

[Tsahi Asher]

oh, that download manager :o

well, umm, oops..

<crawling under the carpet in embaressment>

Comment 9

[Asaf Romano (gone)]

I'll check this soon...

Comment 10

[Asaf Romano (gone)]

This will be solved when the patch for bug 140759 will be checked in, adding
dependence

Comment 11

[Asaf Romano (gone)]

Patch reviewed, change status to ASSIGNED.

Comment 12

[Uri Bernstein]

Fixed as bug 297780?

Comment 13

[Asaf Romano (gone)]

Er, that bug is for undetermined progress-meter.

Comment 14

[Simon Montagu :smontagu]

FIXED, presumably by 140759 as comment 10 says