1433448 - fix distribution matching logic for update query v6

Status: RESOLVED FIXED

(Release Engineering Graveyard :: Applications: Balrog (backend), enhancement, P1)

Description

[[e-mail] (:bhearsum)]

While investigating https://sentry.prod.mozaws.net/operations/prod-public/issues/1405216/ (which turned out to be Rule misconfiguration) I discovered that we're not looking at "distribution" or "distVersion" for update query v6 (https://github.com/mozilla/balrog/blob/87dec526c65a3ebb2c0b6152f627ec66335570b8/auslib/db.py#L1591).

This could cause serious problems - like matching Rules with "distribution" set even though the update query has a mismatched string. Eg: if we were to have completed bug 1430254 and not caught this in staging, we would've ended up serving useless MARs to everyone repeatedly.

I looked through rules and rules_history, and it looks like we've almost never used this in production -- there are no instances of us ever using it for Firefox, one instance of using it for Thunderbird (where it looks like it was a mistake), and a bunch of uses for System Addons. Most of the System Addons ones were very recent, and only a test channel. There are a few older ones that do set it to "default":
|     324 | SystemAddons | release          | <45.0   | SystemAddons-ff44-loop-3.1.0-Superblob                                     | default      |
|     393 | SystemAddons | release          | <45.0   | SystemAddons-ff44-loop-3.1.0-Superblob                                     | default      |
|     395 | SystemAddons | release          | <44.0   | SystemAddons-no-update                                                     | default      |


I'm getting a patch prepared for this.

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/balrog/pull/459

Comment 2

[[github robot]]

Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/f3f9c173f5a20eca3c289b0babe63a54ebd77f2a
bug 1433448: fix distribution matching logic for update query v6 (#459). r=jlorenzo

Comment 3

[[e-mail] (:bhearsum)]

This is in production as of ~5pm eastern yesterday.