1433554 - Fullscreen video forces landscape mode

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Audio/Video, defect, P3)

Description

[filman230]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:58.0) Gecko/20100101 Firefox/58.0
Build ID: 20180122225619

Steps to reproduce:

Android 7.0

1 - Open a page with a video
2- Enter in full screen mode


Actual results:

The phone enters directly in landscape mode when activating full screen mode even if auto-rotate screen is disabled, and exits only after disabling full screen.


Expected results:

The video should be playable in portrait mode.

Happens only in Nightly version, Beta and Release are fine.

Comment 1

[Jan Henning [:JanH]]

That was bug 842782, but now that you mention it I do indeed wonder whether instead of forcing the orientation one way or other depending on the video's aspect ratio, we should merely unlock the orientation sensor for landscape videos, although maybe that would break somebody else's favourite way of using Firefox?

In the mean time, for now you can disable this by changing "media.videocontrols.lock-video-orientation" in about:config.

Comment 2

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Thanks for flaggin this JanH!

I'm not sure how much of an issue this is. Most aspect ratios are more friendly to wide screens vs tall screens. 

Unlocking the orientation sensor could be problematic as well. We have to make some assumptions there like the user remembering they had set the orientation lock (on or off), and that they understand we are overriding a general phone-level setting, and so on.

I'd say this is relatively low priority for now, let's keep an eye on this for the time being.

Comment 3

[filman230]

(In reply to Jan Henning [:JanH] from comment #1)
> That was bug 842782, but now that you mention it I do indeed wonder whether
> instead of forcing the orientation one way or other depending on the video's
> aspect ratio, we should merely unlock the orientation sensor for landscape
> videos, although maybe that would break somebody else's favourite way of
> using Firefox?
> 
> In the mean time, for now you can disable this by changing
> "media.videocontrols.lock-video-orientation" in about:config.

Thank for your reply ! In my opinion, this behavior can be pretty annoying, simply because it forces the whole system to rotate. Now it's not really a problem for me because there is an option, but I don't know how others users would react.

Otherwise, I suspected it was a feature, but in really rares cases it allows me to play a video vertically, so I wasn't sure.

Comment 4

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.