Closed Bug 1433576 Opened 6 years ago Closed 6 years ago

Change timebase used in RTCRtpContributingSource and RTCRtpSynchronizationSource

Categories

(Core :: WebRTC, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: ng, Assigned: ng)

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

This changes the timebase and the clock that is used for timestamps reported on RTCRtpContributingSource and RTCRtpSynchronizationSource objects.
Attachment #8945906 - Flags: review?(jib)
Assignee: nobody → na-g
Rank: 15
Summary: Change RTP Source timebase in JS and comparable clock → Change timebase used in RTCRtpContributingSource and RTCRtpSynchronizationSource
Comment on attachment 8945906 [details]
Bug 1433576 - bring rtp sources js timestamp and timebase up to spec

https://reviewboard.mozilla.org/r/215986/#review221818

::: dom/media/tests/mochitest/test_peerConnection_audioSynchronizationSources.html:44
(Diff revision 1)
> -      ok(Number.isInteger(source.timestamp),
> -        `Synchronization source timestamp is int (${source.timestamp})`);
> +      ok(window.performance.now() + window.performance.timeOrigin -
> +         source.timestamp < 1000, // This large value is used because sometimes

I'd use 5000. 1 second isn't that much on some of our testing infra.
Attachment #8945906 - Flags: review?(jib) → review+
Comment on attachment 8945906 [details]
Bug 1433576 - bring rtp sources js timestamp and timebase up to spec

https://reviewboard.mozilla.org/r/215986/#review221818

> I'd use 5000. 1 second isn't that much on some of our testing infra.

Going with 2500. If that isn't enough, it can be changed later.
This work is required for supporting Google's Meet service working on Firefox, and brings our implementation closer to the spec changes around timestamps[0].

[0] https://github.com/w3c/webrtc-pc/issues/1690
Pushed by na-g@nostrum.com:
https://hg.mozilla.org/integration/autoland/rev/9b144f79e512
bring rtp sources js timestamp and timebase up to spec r=jib
https://hg.mozilla.org/mozilla-central/rev/9b144f79e512
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Updated the compatibility data for RTCRtpContributingSource to note this change for Firefox 60, and added a mention to Firefox 60 for developers.
You need to log in before you can comment on or make changes to this bug.