1433576 - Change timebase used in RTCRtpContributingSource and RTCRtpSynchronizationSource

Status: RESOLVED FIXED

(Core :: WebRTC, enhancement, P1)

Description

[Nico Grunbaum [:ng, @chew:mozilla.org]]

This changes the timebase and the clock that is used for timestamps reported on RTCRtpContributingSource and RTCRtpSynchronizationSource objects.

Comment 1

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1433576 - bring rtp sources js timestamp and timebase up to spec

Review commit: https://reviewboard.mozilla.org/r/215986/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/215986/

Comment 2

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 8945906 [details]
Bug 1433576 - bring rtp sources js timestamp and timebase up to spec

https://reviewboard.mozilla.org/r/215986/#review221818

::: dom/media/tests/mochitest/test_peerConnection_audioSynchronizationSources.html:44
(Diff revision 1)
> -      ok(Number.isInteger(source.timestamp),
> -        `Synchronization source timestamp is int (${source.timestamp})`);
> +      ok(window.performance.now() + window.performance.timeOrigin -
> +         source.timestamp < 1000, // This large value is used because sometimes

I'd use 5000. 1 second isn't that much on some of our testing infra.

Comment 3

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Comment on attachment 8945906 [details]
Bug 1433576 - bring rtp sources js timestamp and timebase up to spec

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/215986/diff/1-2/

Comment 4

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Comment on attachment 8945906 [details]
Bug 1433576 - bring rtp sources js timestamp and timebase up to spec

https://reviewboard.mozilla.org/r/215986/#review221818

> I'd use 5000. 1 second isn't that much on some of our testing infra.

Going with 2500. If that isn't enough, it can be changed later.

Comment 5

[Nico Grunbaum [:ng, @chew:mozilla.org]]

This work is required for supporting Google's Meet service working on Firefox, and brings our implementation closer to the spec changes around timestamps[0].

[0] https://github.com/w3c/webrtc-pc/issues/1690

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9b144f79e512
bring rtp sources js timestamp and timebase up to spec r=jib

Comment 7

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/9b144f79e512

Comment 8

[Eric Shepherd [:sheppy]]

Updated the compatibility data for RTCRtpContributingSource to note this change for Firefox 60, and added a mention to Firefox 60 for developers.