1433617 - Very frequent TEST-UNEXPECTED-TIMEOUT | /content-security-policy/prefetch-src/prefetch-allowed.html | Prefetch succeeds when allowed by prefetch-src - Test timed out

Status: RESOLVED FIXED

(Core :: DOM: Security, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: philringnalda [at] gmail.com

https://treeherder.mozilla.org/logviewer.html#?job_id=158810315&repo=mozilla-inbound

https://queue.taskcluster.net/v1/task/GbDY63D0TI2nEYrJHoD7kw/runs/0/artifacts/public/logs/live_backing.log

Comment 1

[Intermittent Failures Robot]

15 failures in 701 pushes (0.021 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* mozilla-inbound: 15

Platform breakdown:
* windows7-32: 15

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1433617&startday=2018-01-22&endday=2018-01-28&tree=all

Comment 2

[Andreea Pavel [:apavel]]

This also occurs on Linux opt (failure log): https://treeherder.mozilla.org/logviewer.html#?job_id=159527824&repo=mozilla-inbound&lineNumber=1574

Comment 3

[Intermittent Failures Robot]

31 failures in 735 pushes (0.042 failures/push) were associated with this bug in the last 7 days. 

This is the #31 most frequent failure this week.  

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **  

Repository breakdown:
* mozilla-inbound: 12
* mozilla-central: 9
* autoland: 9
* try: 1

Platform breakdown:
* linux64: 11
* linux32: 6
* linux64-stylo-disabled: 5
* linux32-stylo-disabled: 5
* osx-10-10: 4

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1433617&startday=2018-01-29&endday=2018-02-04&tree=all

Comment 4

[Tiberius Oros[:tiberius_oros]]

There have been 40 failures in the last week.

Occurrences per platform:
- Linux x64: 14
- linux64-stylo-disabled: 8
- Linux: 8
- linux32-stylo-disabled: 6
- OS X 10.10: 3
- windows10-64: 1

Occurrences per build type:
- opt: 32
- pgo: 7
- debug: 1

Here is a recent relevant log file and a snippet with the failure:
https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=160956801&lineNumber=1591

[task 2018-02-07T23:25:30.186Z] 23:25:30     INFO - TEST-PASS | /content-security-policy/prefetch-src/prefetch-allowed.html | Browser supports prefetch. 
[task 2018-02-07T23:25:30.186Z] 23:25:30     INFO - TEST-PASS | /content-security-policy/prefetch-src/prefetch-allowed.html | Browser supports performance APIs. 
[task 2018-02-07T23:25:30.186Z] 23:25:30     INFO - TEST-UNEXPECTED-TIMEOUT | /content-security-policy/prefetch-src/prefetch-allowed.html | Prefetch succeeds when allowed by prefetch-src - Test timed out
[task 2018-02-07T23:25:30.186Z] 23:25:30     INFO - TEST-INFO | expected FAIL
[task 2018-02-07T23:25:30.187Z] 23:25:30     INFO - TEST-UNEXPECTED-TIMEOUT | /content-security-policy/prefetch-src/prefetch-allowed.html | expected OK
[task 2018-02-07T23:25:30.187Z] 23:25:30     INFO - TEST-INFO took 10188ms

Comment 5

[Intermittent Failures Robot]

38 failures in 702 pushes (0.054 failures/push) were associated with this bug in the last 7 days. 

This is the #33 most frequent failure this week.  

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **  

Repository breakdown:
* autoland: 15
* mozilla-inbound: 10
* mozilla-central: 6
* pine: 5
* try: 2

Platform breakdown:
* linux64: 12
* linux64-stylo-disabled: 9
* linux32: 8
* linux32-stylo-disabled: 5
* osx-10-10: 3
* windows10-64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1433617&startday=2018-02-05&endday=2018-02-11&tree=all

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

:ckerschb, this was filed in the wrong component- moving to your area to get the right people looking at it.

Comment 7

[Christoph Kerschbaumer [:ckerschb, back Sept 8th]]

Vino, can you also have a look at this one please!

Comment 8

[Intermittent Failures Robot]

38 failures in 685 pushes (0.055 failures/push) were associated with this bug in the last 7 days. 

This is the #36 most frequent failure this week.  

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **  

Repository breakdown:
* autoland: 15
* mozilla-inbound: 13
* mozilla-central: 7
* try: 3

Platform breakdown:
* linux64: 13
* linux64-stylo-disabled: 9
* linux32: 9
* linux32-stylo-disabled: 4
* osx-10-10: 3

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1433617&startday=2018-02-12&endday=2018-02-18&tree=all

Comment 9

[Cristina Coroiu [:ccoroiu]]

In the last 7 days, there have been 34 failures.

For the failure pattern see Comment 4

An example of a recent log file:
https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-central&job_id=162979819&lineNumber=1565

:ckerschb, :vinoth are there any updates here?

Comment 10

[Christoph Kerschbaumer [:ckerschb, back Sept 8th]]

(In reply to Cristina Coroiu [:ccoroiu] from comment #9)
> In the last 7 days, there have been 34 failures.

:ccoroiu, how much of a problem is 34 failures? Does that put this bug in the bucket with the most intermittent failures? I think we can prioritize this intermittent over others if needed. Please let me know.

Comment 11

[Andreea Pavel [:apavel]]

:ckerschb the issue here is that every week there are ~30/40/50 failures (i checked this month only), which means that this failure is a priority. If you have other failures or more important tasks, feel free to postpone this, but it still needs a fix sooner, rather than later. 

Thanks.

Comment 12

[Christoph Kerschbaumer [:ckerschb, back Sept 8th]]

(In reply to Andreea Pavel [:apavel] from comment #11)
> :ckerschb the issue here is that every week there are ~30/40/50 failures (i
> checked this month only), which means that this failure is a priority. If
> you have other failures or more important tasks, feel free to postpone this,
> but it still needs a fix sooner, rather than later. 


kk - thanks for the info. I'll make sure we look into that rather sooner than later then - thanks!

Comment 13

[Andreea Pavel [:apavel]]

:ckerschb great! thank you!

Comment 14

[Vinothkumar Nagasayanan [:vinoth]]

I will look into it.

Comment 15

[Phabricator Automation]

Attachment: Bug 1433617 - sleep function added to waitUntilResourceDownloaded method

Comment 16

[Vinothkumar Nagasayanan [:vinoth]]

(In reply to Phabricator Automation from comment #15)
> Created attachment 8953470 [details]
> Bug 1433617 - sleep function added to waitUntilResourceDownloaded method

Tested it in Try server,
https://treeherder.mozilla.org/#/jobs?repo=try&revision=11c56d996ad8c43ecfa0ed9eefc9ba28eb235383

Now the test is getting PASSED. I think because of continuous failure, test is now expecting TIMEOUT itseems,
https://treeherder.mozilla.org/logviewer.html#?job_id=163948458&repo=try&lineNumber=1601

Prefetch-helper.js file,
https://dxr.mozilla.org/mozilla-central/source/testing/web-platform/tests/content-security-policy/support/prefetch-helper.js#11

Main reason for the timeout error is, performance.getEntriesByName() is getting the Prefetched Image in few seconds delay. And the function waitUntilResourceDownloaded returns before the image is added to the performance.getEntriesByName() list. 
Hence I added 500ms delay.

Comment 17

[Vinothkumar Nagasayanan [:vinoth]]

Comment on attachment 8953470 [details]
Bug 1433617 - sleep function added to waitUntilResourceDownloaded method

Still the issue exists.So marking as Obsolete

Comment 18

[Intermittent Failures Robot]

32 failures in 675 pushes (0.047 failures/push) were associated with this bug in the last 7 days. 

This is the #42 most frequent failure this week.  

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **  

Repository breakdown:
* autoland: 13
* mozilla-central: 10
* mozilla-inbound: 7
* try: 2

Platform breakdown:
* linux64-stylo-disabled: 10
* linux64: 7
* linux32-stylo-disabled: 6
* linux32: 5
* linux64-nightly: 2
* osx-10-10: 1
* linux32-nightly: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1433617&startday=2018-02-19&endday=2018-02-25&tree=all

Comment 19

[Intermittent Failures Robot]

49 failures in 831 pushes (0.059 failures/push) were associated with this bug in the last 7 days. 

This is the #28 most frequent failure this week.  

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **  

Repository breakdown:
* autoland: 15
* try: 13
* mozilla-inbound: 13
* mozilla-central: 7
* mozilla-beta: 1

Platform breakdown:
* linux64: 21
* linux64-stylo-disabled: 8
* osx-10-10: 7
* linux32: 5
* linux32-stylo-disabled: 4
* macosx64-devedition: 1
* linux64-nightly: 1
* linux32-nightly: 1
* linux32-devedition: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1433617&startday=2018-02-26&endday=2018-03-04&tree=all

Comment 20

[Tiberius Oros[:tiberius_oros]]

Update:
There have been 44 failures in the last week and 105 failures in the last 21 days.

Failures per platforms in the last 7 days:
- Linux x64: 17
- linux64-stylo-disabled: 9
- linux32-stylo-disabled: 6
- OS X 10.10: 6
- Linux: 6

Failures per build type in the last 7 days:
- opt: 38
- pgo: 6

Here is a recent log file and a snippet with the failure:
https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=166013057&lineNumber=1557

[task 2018-03-05T16:26:30.061Z] 16:26:30     INFO - TEST-START | /content-security-policy/prefetch-src/prefetch-allowed.html
[task 2018-03-05T16:26:30.086Z] 16:26:30     INFO - Setting pref security.mixed_content.upgrade_display_content (false)
[task 2018-03-05T16:26:30.134Z] 16:26:30     INFO - Setting pref security.csp.enable_violation_events (true)
[task 2018-03-05T16:26:40.372Z] 16:26:40     INFO - 
[task 2018-03-05T16:26:40.372Z] 16:26:40     INFO - TEST-PASS | /content-security-policy/prefetch-src/prefetch-allowed.html | Browser supports prefetch. 
[task 2018-03-05T16:26:40.373Z] 16:26:40     INFO - TEST-PASS | /content-security-policy/prefetch-src/prefetch-allowed.html | Browser supports performance APIs. 
[task 2018-03-05T16:26:40.373Z] 16:26:40     INFO - TEST-UNEXPECTED-TIMEOUT | /content-security-policy/prefetch-src/prefetch-allowed.html | Prefetch succeeds when allowed by prefetch-src - Test timed out
[task 2018-03-05T16:26:40.373Z] 16:26:40     INFO - TEST-INFO | expected FAIL
[task 2018-03-05T16:26:40.374Z] 16:26:40     INFO - TEST-UNEXPECTED-TIMEOUT | /content-security-policy/prefetch-src/prefetch-allowed.html | expected OK
[task 2018-03-05T16:26:40.374Z] 16:26:40     INFO - TEST-INFO took 10316ms
[task 2018-03-05T16:26:40.536Z] 16:26:40     INFO - PID 2072 | *** UTM:SVC TimerManager:registerTimer called after profile-before-change notification. Ignoring timer registration for id: telemetry_modules_ping
[task 2018-03-05T16:26:40.839Z] 16:26:40     INFO - Browser exited with return code 0

:ckerschb is there somebody that can take another look at this?
I see that :vinoth tried to make a patch, but the issue still exists.

Comment 21

[Christoph Kerschbaumer [:ckerschb, back Sept 8th]]

:jkt, any chance you could take a quick look and see if you can identify the problem?

Comment 22

[Phabricator Automation]

Attachment: Bug 1433617 - Cache control headers added to png image

Comment 23

[Vinothkumar Nagasayanan [:vinoth]]

(In reply to Phabricator Automation from comment #22)
> Created attachment 8957087 [details]
> Bug 1433617 - Cache control headers added to png image

Main problem is, Cache control header need to be set for the resources from the server side to enable prefetching. 

Cache control check is done here,
https://dxr.mozilla.org/mozilla-central/rev/a859a4b2257e6c61f7c2aab456cf551df856bd95/uriloader/prefetch/nsPrefetchService.cpp#260

It was missing previously in the test, hence added it.

Now I will push these changes to try server and figure out if the tests are passing. I will update the results.

Comment 24

[Jonathan Kingston [:jkt] he/him]

Patch from :vinoth works for me :)

Comment 25

[Jonathan Kingston [:jkt] he/him]

The only change needed it to enable the test again: https://searchfox.org/mozilla-central/rev/588d8120aa11738657da93e09a03378bcd1ba8ec/testing/web-platform/meta/content-security-policy/prefetch-src/prefetch-allowed.html.ini

Comment 26

[Intermittent Failures Robot]

34 failures in 747 pushes (0.046 failures/push) were associated with this bug in the last 7 days. 

This is the #39 most frequent failure this week.  

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **  

Repository breakdown:
* mozilla-inbound: 14
* autoland: 9
* try: 5
* mozilla-central: 5
* mozilla-beta: 1

Platform breakdown:
* linux64: 12
* osx-10-10: 6
* linux64-stylo-disabled: 6
* linux32-stylo-disabled: 5
* linux32: 3
* macosx64-devedition: 1
* linux32-nightly: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1433617&startday=2018-03-05&endday=2018-03-11&tree=all

Comment 27

[Intermittent Failures Robot]

13 failures in 141 pushes (0.092 failures/push) were associated with this bug yesterday.    

** This test has failed more than 150 times in the last 21 days. It should be disabled until it can be fixed. ** 

Repository breakdown:
* mozilla-inbound: 5
* autoland: 5
* try: 2
* mozilla-beta: 1

Platform breakdown:
* linux64: 4
* linux32: 3
* linux32-stylo-disabled: 2
* macosx64-nightly: 1
* macosx64-devedition: 1
* linux64-stylo-disabled: 1
* linux32-nightly: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1433617&startday=2018-03-14&endday=2018-03-14&tree=all

Comment 28

[Andrei Ciure[:aciure]]

Update:
There have been 32 failures in the last week and they are occurring on Linux platforms.

:ckerschb :jkt any updates on this one?

Comment 29

[Intermittent Failures Robot]

46 failures in 814 pushes (0.057 failures/push) were associated with this bug in the last 7 days. 

This is the #28 most frequent failure this week.  

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **  

Repository breakdown:
* autoland: 15
* mozilla-inbound: 14
* mozilla-central: 10
* try: 4
* mozilla-beta: 3

Platform breakdown:
* linux64: 16
* linux32: 9
* linux64-stylo-disabled: 7
* linux32-stylo-disabled: 7
* osx-10-10: 2
* macosx64-devedition: 2
* linux32-nightly: 2
* macosx64-nightly: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1433617&startday=2018-03-12&endday=2018-03-18&tree=all

Comment 30

[Vinothkumar Nagasayanan [:vinoth]]

(In reply to Andrei Ciure[:andrei_ciure_] from comment #28)
> Update:
> There have been 32 failures in the last week and they are occurring on Linux
> platforms.
> 
> :ckerschb :jkt any updates on this one?

New patch works locally for myself and jkt.
But on linux 64 platform alone it throws timeout error, in try server[1]
Hence working on finding the cause.

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=22101f28d89f5788e488117fe3568617d803f321&selectedJob=166990950

Comment 31

[Christoph Kerschbaumer [:ckerschb, back Sept 8th]]

(In reply to Andrei Ciure[:andrei_ciure_] from comment #28)
> Update:
> There have been 32 failures in the last week and they are occurring on Linux
> platforms.
> 
> :ckerschb :jkt any updates on this one?

:vino is on it!

Comment 32

[Vinothkumar Nagasayanan [:vinoth]]

Comment on attachment 8957087 [details]
Bug 1433617 - Cache control headers added to png image

Main problem before is, Cache control header need to be set for the resources from the server side to enable prefetching. It was missing previously, hence added it.
Reason for using a new window for prefetch is, because prefetch is of low priority and it is being interrupted by the test runner in the same file.
These issues are fixed in the patch.

Tested it in try server,
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b927ed56be7529becfdaba0d102c0d0e9ce5e76c

Comment 33

[Phabricator Automation]

Comment on attachment 8957087 [details]
Bug 1433617 - Cache control headers added to png image

Christoph Kerschbaumer [:ckerschb] has approved the revision.

https://phabricator.services.mozilla.com/D697

Comment 34

[Vinothkumar Nagasayanan [:vinoth]]

Latest try server push after fixing all comments,
https://treeherder.mozilla.org/#/jobs?repo=try&revision=98a2185d6d3bfd349887838e156a9ee06df51494

Comment 35

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e84c93b3a8ab
Cache control headers added to png image. r=ckerschb

Comment 36

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/e84c93b3a8ab

Comment 37

[Intermittent Failures Robot]

34 failures in 822 pushes (0.041 failures/push) were associated with this bug in the last 7 days.   

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **  

Repository breakdown:
* autoland: 12
* mozilla-inbound: 9
* mozilla-central: 7
* mozilla-beta: 4
* try: 2

Platform breakdown:
* linux64: 14
* linux32: 9
* osx-10-10: 3
* macosx64-nightly: 2
* windows7-32: 1
* macosx64-devedition: 1
* linux64-stylo-disabled: 1
* linux64-nightly: 1
* linux64-devedition: 1
* linux32-stylo-disabled: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1433617&startday=2018-03-20&endday=2018-03-26&tree=trunk

Comment 38

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/2ac29892c969

Comment 39

[Intermittent Failures Robot]

9 failures in 718 pushes (0.013 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* mozilla-inbound: 3
* autoland: 3
* mozilla-beta: 2
* try: 1

Platform breakdown:
* linux64: 4
* windows7-32: 2
* macosx64-nightly: 2
* macosx64-devedition: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1433617&startday=2018-03-26&endday=2018-04-01&tree=trunk

Comment 40

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/w3c/web-platform-tests/pull/10306 for changes under testing/web-platform/tests