1433637 - Favicons are shown in Bookmarks Toolbar even if Firefox is configured not to show them

Status: RESOLVED DUPLICATE of bug 1423506

(Firefox :: Bookmarks & History, defect)

Description

[martin]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:58.0) Gecko/20100101 Firefox/58.0
Build ID: 20180123231643

Steps to reproduce:

Steps to reproduce:

1. Start Firefox with new profile.
2. Open "about:config" page.
3. Set preference "browser.chrome.favicons" to false.
4. Set preference "browser.chrome.site_icons" to false.
5. Restart Firefox.
6. Make Bookmarks Toolbar visible.
7. Open URL "https://www.google.de/".
8. Drag "(i)" (i in a circle) icon from Location Bar to Bookmark Toolbar.
9. Restart Firefox.

Observed behavior: The Google icon (colored G on a white background) is
displayed next to the Google bookmark text in the Bookmark Toolbar.

Expected behavior: A generic icon is displayed next to the Google bookmark
text in the Bookmark Toolbar.

Additional information: Inspection of favicons.sqlite shows that the URL
https://www.google.de/images/branding/product_ios/3x/gsa_ios_60dp.png#tippytop
is referenced in the moz_icons table.

I could reproduce this bug with one other site, "https://www.heise.de/". The
corresponding URL that appears in favicons.sqlite is
https://www.heise.de/icons/ho/apple-touch-icon-152.png#tippytop.

An analysis of the network traffic shows that if I delete favicons.sqlite,
Firefox fetches the icons from their upstream sites as soon as it is
started. In addition to being unwanted, this therefore constitutes a breach
of privacy by contacting web servers without user interaction.

I observed this bug with Firefox 58.0 on Linux (Build ID 20180123231643),
but could not reproduce it with Firefox 57 on Linux.



Actual results:

The Google icon (colored G on a white background) is displayed next to the Google bookmark text in the Bookmark Toolbar.


Expected results:

A generic icon is displayed next to the Google bookmark text in the Bookmark Toolbar.

Comment 1

[Adrian Florinescu [:aflorinescu]]

Reproduced the issue on: 60.0a1 20180130223236 and 58.0.1 20180128191252.
Martin, since you say it's a regression from 57, would you be willing to run a mozregression (http://mozilla.github.io/mozregression/) to find which change introduced this bug?

Comment 2

[Alice0775 White]

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=04dac3301ecdea203603c8876f6bcb06cd6bca86&tochange=b4d1db669c93f605c23c7b8271bd31a097cf492f

Regressed by:
b4d1db669c93	Ed Lee — Bug 1415812 - Fix broken Pocket disclaimer, missing rich icons and bug fixes to Activity Stream. r=k88hudson


Indeed, Setting browser.newtabpage.activity-stream.enabled = false fixes the problem.



@Ed Lee :Mardak
Your patch causes the regression, can you look into this?

Comment 3

[Alice0775 White]

Regression window for beta channel:
https://hg.mozilla.org/releases/mozilla-beta/pushloghtml?fromchange=7649c04f02c36e8fc07c1e87637b1cea9f3ba823&tochange=18524c7a40b32c1bbc5d47bf8f0fa8c80fdd0cb1

Suspect: Bug 1421306

@Ricky Rosario,
And also your patch seems to cause regression in beta channel.

Comment 5

[martin]

After trying a beta version, as described in bug 1423506, I can confirm that the bug no longer occurs in Firefox 59.0b5 (Build ID 20180128191456). As far as I'm concerned, the issue is resolved. Thank you!

(I assume running mozregression is not needed any more.)