1433670 - Add-on install whitelist occasionally forgets addons.mozilla.org

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Settings and Preferences, enhancement)

Description

[Jan Henning [:JanH]]

Occasionally I'm getting the message that add-on installation has been blocked even on https://addons.mozilla.org, and apparently this happens to others as well (https://www.reddit.com/r/firefox/comments/7tcx3w/help_blocked_addon/).

Resetting "xpinstall.whitelist.add" and restarting Firefox fixes this, but it might eventually happen again and of course it shouldn't even have ever occurred in the first place.

Comment 1

[Jan Henning [:JanH]]

Thanks to a helpful comment from that Reddit thread, I've realised that this happens when Site Settings are cleared.

The problem is that after clearing site settings our default permissions (xpinstall.whitelist.add) aren't restored.
A quick fix would be to add some code to PermissionsUtils.jsm that
a) resets the corresponding prefs themselves [1]
b) and the list of prefs that have already been imported [2]

and call that when clearing Site Settings through our Sanitizer [3].

A more holistic approach would be to finally tackle bug 1072744 so we're back to using the same system as Desktop.

[1] https://dxr.mozilla.org/mozilla-central/rev/e22e2c9eb81686e958a9448ea3d1e8cd766743e2/toolkit/modules/PermissionsUtils.jsm#89-92
[2] PermissionsUtils.jsm
[3] https://dxr.mozilla.org/mozilla-central/rev/e22e2c9eb81686e958a9448ea3d1e8cd766743e2/mobile/android/modules/Sanitizer.jsm#124-125

Comment 2

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.