1433696 - Some videos display as black or green rectangles with webrender on. (ANGLE/Win7 ?)

Status: RESOLVED DUPLICATE of bug 1440849

(Core :: Graphics: WebRender, defect, P1)

Description

[slew]

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:59.0) Gecko/20100101 Firefox/59.0
Build ID: 20100101

Steps to reproduce:

Install reddit enhancement suite
Turn on gfx.webrender.all, restart browser
Visit a reddit page with many gifs, for example https://www.reddit.com/r/gifs/
Attempt to load all gifs inline using the 'Show images' button from reddit enhancement suite.


Actual results:

Most videos show as black or green rectangles. Clicking the links to visit a new page sometimes loads black rectangles.


Expected results:

The videos should display inline and on the image hosts pages.

Comment 1

[Darkspirit]

Thanks!

"Show images (60)" will be the last tab in the header.
mozregression --launch 2018-01-27 --pref gfx.webrender.all:true startup.homepage_welcome_url:"https://addons.mozilla.org/en-US/firefox/addon/reddit-enhancement-suite/|https://www.reddit.com/r/gifs/"

I can't reproduce it on Debian Testing (KDE, Radeon RX480).

Comment 2

[slew]

I forgot to add, Windows 7 x64, nVidia GTX 770, drivers are 390.65.

Comment 3

[Milan Sreckovic [:milan] (needinfo for best results)]

Slew, do you have access to Windows 10?  Same problem there?

Comment 4

[slew]

Sorry I don't wish to install Windows 10 on this machine. Is it okay if I test it on another machine?

On an older machine with an older build of Windows 10 the bug doesn't happen, Geforce320M and Windows 10 build 1511

Comment 5

[Darkspirit]

Could you make a screenshot of the problem and upload it here (Attach File)?
Do you use multiple windows or does this problem already happen if you start Nightly with one window and open Reddit then?

Comment 6

[slew]

Attachment: Screenshot 1.png

Comment 7

[slew]

Attachment: Screenshot 2.png

Comment 8

[slew]

Attachment: Screen Shot 2018-01-29 at 19.07.14-fullpage.jpg

Comment 9

[slew]

I use multiple windows but before I report any bug I make a new profile using the profile manager and follow the exact steps I put on the bug. So I guess this is one window and reddit. An interesting thing I discovered was that the inbuilt screenshot function displays the image just fine (Screen Shot 2018-01-29 at 19.07.14-fullpage.jpg).

On my display you can see on screenshot 1 that most images are green rectangles (sometimes black), in screenshot 2 not all images have that issue.

Comment 10

[Darkspirit]

Just for curiosity: Would it help to set gfx.webrender.all to true and gfx.webrender.force-angle to false?

Comment 11

[slew]

Yes that fixes this problem. However it makes the window decorations (which are already broken in bug 1416288) even more broken.

Comment 12

[Darkspirit]

Could you also make a screenshot of that, please?

Comment 13

[slew]

Attachment: offtopic: gfx.webrender.force-angle;false

The min/max/close buttons are now black, as well as all the glass themed top being solid white.

Comment 14

[Sotaro Ikeda [:sotaro]]

When I tested the STR in comment 0 locally with 3 win10 PCs, but I could not reproduce the problem.

Comment 15

[Sotaro Ikeda [:sotaro]]

I tested the STR of comment 0 on my win7 PCs and I seemed to reproduce the problem.

When I turn on WebRender with "gfx.webrender.all", I saw the some videos were not rendered correctly. Instead some video were rendered as black or green rectangles.

When I turn on WebRender with "gfx.webrender.enabled", I saw that all videos and almost all images were rendered as black. The difference seemed to come from "gfx.webrender.blob-images". They prevent to use D3D Texture as data storage for images and fallbacked images.

Comment 16

[Sotaro Ikeda [:sotaro]]

From comment 15, it seems that somehow direct d3d texture binding seemed not work with ANGLE. One possible problem is driver's problem. When I disabled WebRender and opened "about:support", there were "NO_CONSTANT_BUFFER_OFFSETTING : Unsupported by driver", when "Direct3d 11 (Advanced Layers)" was used as compositor.

NO_CONSTANT_BUFFER_OFFSETTING check was added to MLGDevice by Bug 1379413. It handles the case that driver does not support constant buffer offsetting.

Comment 17

[Sotaro Ikeda [:sotaro]]

In Bug 1379413, when driver does not support constant buffer offsetting, MLGDeviceD3D11 disables ID3D11DeviceContext1::[V|P]SSetConstantBuffers1 usages.

But ANGLE uses ID3D11DeviceContext1::[V|P]SSetConstantBuffers1 in StateManager11::syncUniformBuffers()
 > https://dxr.mozilla.org/mozilla-central/source/gfx/angle/src/libANGLE/renderer/d3d/d3d11/StateManager11.cpp#2888
 > https://dxr.mozilla.org/mozilla-central/source/gfx/angle/src/libANGLE/renderer/d3d/d3d11/StateManager11.cpp#2941

Comment 18

[Sotaro Ikeda [:sotaro]]

But for now, we could just assume that a driver bug might cause the problem.

Comment 19

[Sotaro Ikeda [:sotaro]]

My case was caused by regression of Bug 1415754. When RenderDXGITextureHostOGL and RenderDXGIYCbCrTextureHostOGL does not support ANGLE_stream_producer_d3d_texture_nv12(NV12 format), they does not render d3d texture. Bug 1415754 addressed the crash, but the way of fixing was not good :(

Comment 20

[Sotaro Ikeda [:sotaro]]

Slew, can you confirm if the problem is addressed with latest m-c?

Comment 21

[slew]

I'm not sure what m-c is but the problem is fixed if I reenable force-angle on the latest nightly, yes.

Comment 22

[Sotaro Ikeda [:sotaro]]

Thanks! Sorry, I used m-c for nightly.

Comment 23

[Sotaro Ikeda [:sotaro]]

m-c is short hand notation of mozilla-central