1433754 - login is not automatically filled on fortuneo.fr website

Status: RESOLVED FIXED

(Toolkit :: Password Manager: Site Compatibility, defect, P3)

Description

[Vincent (caméléon)]

My login and password have been saved for the fortuneo website in Firefox's password manager.

However, when I go to https://mabanque.fortuneo.fr/fr/identification.jsp :

my login is not filled
the password is filled with my login information!

Comment 1

[Julien Wajsberg [:julienw]]

Still doesn't work.

Comment 2

[Julien Wajsberg [:julienw]]

Note: I'm willing to provide a patch with some guidance, as this is painful to me on a regular basis.

Comment 3

[Vincent (caméléon)]

Glad to heard that! Do you know if this a Firefox bug, or a problem with Fortuneo's Website?

Comment 4

[Matthew N. [:MattN]]

Attachment: Subset of the page showing two forms

They are using separate <form>s for the username and password fields which is very unusual.

I would say this is more of a website problem than a Firefox problem as I've never seen another website do this before.

When I test the password field is filled fine, just not the username field. This makes sense since we don't support filling just the username with no password.

Julien, I think the best option at this time would be to make a recipe for this in https://searchfox.org/mozilla-central/source/toolkit/components/passwordmgr/content/recipes.json

You probably need one like:

    {
      "description": "…",
      "hosts": ["mabanque.fortuneo.fr"],
      "pathRegex": "\/identification\.jsp$",
      "usernameSelector": "input[name='LOGIN']"
    }

I can review if you test it.

Comment 5

[Julien Wajsberg [:julienw]]

Attachment: Bug 1433754 - Fix username filling on Fortuneo website

Comment 6

[Julien Wajsberg [:julienw]]

This worked, I just had to change the regexp to escape the backslashes :)

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/877169d8ef49
Fix username filling on Fortuneo website r=MattN

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/877169d8ef49

Comment 9

[Julien Wajsberg [:julienw]]

Hey Matt, thanks for the push!
Over the week-end, I've been wondering: the logic was properly saving the username/password from the form (so it was handling the several forms just fine in that case), but just not filling the form at load time. Therefore I wonder if the logic may need a more general fix. What do you think?

Comment 10

[Matthew N. [:MattN]]

Sorry, I'm a bit confused… are you talking about the behaviour before your fix or after?

Before your fix I think the username shouldn't have been getting saved, only the password.

Are you saying that your fix didn't work? It appears to work for me but since I don't have a valid credential I can't be sure it would submit properly.

Comment 11

[Julien Wajsberg [:julienw]]

Sorry, I'm a bit confused… are you talking about the behaviour before your fix or after?

I'm talking about the behavior before the fix.

The username was getting saved, but wasn't being filled at load time.

After the fix both behaviors work :) But the above behavior makes me thing there may be an underlying bug.

Comment 12

[Matthew N. [:MattN]]

(In reply to Julien Wajsberg [:julienw] from comment #11)

I'm talking about the behavior before the fix.

The username was getting saved, but wasn't being filled at load time.

Aha, good catch! This page has more magic going on than I realized… Neither of the two forms I attached are the ones that get submitted, there is a third hidden form with name "acces_identification" that gets submitted so that's why we saved properly:

<div style="display:none">
	<form name="acces_identification" action="/checkacces" method="POST">
		<input type="hidden" name="locale" value="fr">
		<input type="hidden" name="fingerprint" value="b4fd73c31f1f519b97e5fe1512152945">
		<input type="checkbox" name="rememberme">
		<input type="text" name="login" value="" autocomplete="off">
		<input type="password" name="passwd" value="" autocomplete="off">
		<input type="hidden" name="idDyn" value="false">
	</form>
</div>

I don't think there is another underlying issue to fix. Thanks for checking though.

Comment 13

[Vincent (caméléon)]

I am very glad to see that fix coming soon, thanks a lot for this job!

Comment 14

[Julien Wajsberg [:julienw]]

@mattn: I see, this page is full of surprise. Thanks for checking :)

@Vincent: my pleasure :-)