1433763 - [FTL] Attributes added to existing string are not available for translation in Pontoon

Status: RESOLVED FIXED

(Webtools Graveyard :: Pontoon, enhancement, P1)

Description

[Francesco Lodolo [:flod]]

I assume that's the case for
https://github.com/mozilla-services/screenshots/commit/31bbfb47a8a56def1836a0eff08a950716d19975

One of the two strings is here
https://pontoon.mozilla.org/de/firefox-screenshots/server.ftl/?search=annotationCancelCropButton&string=175039

The 2 strings are not displayed as missing. There's also a weird behavior, where Pontoon shows the "Leave anyway?" dialog, even if I don't touch the string (e.g. click on the string in the left column.

Using FTL Advanced mode and manually adding the attribute seems to work.

Comment 1

[Axel Hecht [:Pike]]

This seems to be because pontoon switches the fields based on the localized attributes and not the original attributes or both.

From a l10n process POV, this is an interesting challenge, should a message get a new key if it adds an attribute? I'm torn.

Comment 2

[Matjaz Horvat [:mathjazz]]

Not being able to translate the attribute from the Fluent UI is just part of the problem.

The other one is that the string shows up as translated. Instead of error.

We can solve both problems if the message gets a new key. Or we could start including attribute keys in the unique string identifier (also called "key" in Pontoon) in addition to the message key. We already do something similar in PO files:
https://github.com/mozilla/pontoon/blob/ad264b90afc5156b64911754530e148c428bdff1/pontoon/sync/formats/po.py#L28

That would also prevent us from importing such half-translations if they are submitted through VCS. (Translate UI already prevents such submissions).

Of course just turning strings into errors would be better, because part of the translation would be kept, but that's blocked by bug 1237667.

Comment 3

[Axel Hecht [:Pike]]

IMHO, we shouldn't add too much work to work around the lack of Lendava. I.e., give to Lendava what is Lendava's.

Recap question, what happens with strings imported that have errors? Are they rejected or translated or suggested?

Comment 4

[Matjaz Horvat [:mathjazz]]

Imported strings are translated. Sync doesn't do any error checking.

Comment 5

[Matjaz Horvat [:mathjazz]]

As decided on the tech call, I filed a bug to change the string ID:
https://github.com/mozilla-services/screenshots/issues/4041

I will also fix the editor for the sake of future cases and cases where half-translation is submitted through VCS.

Comment 6

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pontoon/pull/965

Comment 7

[[github robot]]

Commit pushed to master at https://github.com/mozilla/pontoon

https://github.com/mozilla/pontoon/commit/0e352f050230f1f5c5dbb3ad7d06346a08d4128a
Fix bug 1433763: [FTL] Render untranslated attributes (#965)

If translation doesn't include all entity attributes, we need to
render them in editor anyways (as untranslated).