Closed
Bug 1433846
Opened 7 years ago
Closed 7 years ago
Move nsComputedDOMStyle::GetPresShellForContent into nsContentUtils.
Categories
(Core :: CSS Parsing and Computation, enhancement)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla60
Tracking | Status | |
---|---|---|
firefox60 | --- | fixed |
People
(Reporter: hiro, Assigned: hiro)
Details
Attachments
(3 files)
It's more intuitive that nsContentUtils has the method that returns nsIPresShell* for a given nsIContent*.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=5078f57551eb21574804512a2ab890d859b61636
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8946185 [details]
Bug 1433846 - Fix the comment for nsContentUtils::GetContextForContent().
https://reviewboard.mozilla.org/r/216172/#review222196
Attachment #8946185 -
Flags: review?(xidorn+moz) → review+
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8946186 [details]
Bug 1433846 - Introduce nsContentUtils::GetPresShellForContent(const* nsIContent).
https://reviewboard.mozilla.org/r/216174/#review222198
Attachment #8946186 -
Flags: review?(xidorn+moz) → review+
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8946187 [details]
Bug 1433846 - Drop nsComputedDOMStyle::GetPresShellForContent(), use nsContentUtils::GetPresShellForContent().
https://reviewboard.mozilla.org/r/216176/#review222200
Attachment #8946187 -
Flags: review?(xidorn+moz) → review+
Assignee | ||
Comment 7•7 years ago
|
||
Thank you!
Pushed by hikezoe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/239d24b07fe5
Fix the comment for nsContentUtils::GetContextForContent(). r=xidorn
https://hg.mozilla.org/integration/autoland/rev/d85600fe0ebc
Introduce nsContentUtils::GetPresShellForContent(const* nsIContent). r=xidorn
https://hg.mozilla.org/integration/autoland/rev/5a1d2718c712
Drop nsComputedDOMStyle::GetPresShellForContent(), use nsContentUtils::GetPresShellForContent(). r=xidorn
Comment 9•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/239d24b07fe5
https://hg.mozilla.org/mozilla-central/rev/d85600fe0ebc
https://hg.mozilla.org/mozilla-central/rev/5a1d2718c712
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in
before you can comment on or make changes to this bug.
Description
•