1433846 - Move nsComputedDOMStyle::GetPresShellForContent into nsContentUtils.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Hiroyuki Ikezoe (:hiro)]

It's more intuitive that nsContentUtils has the method that returns nsIPresShell* for a given nsIContent*.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5078f57551eb21574804512a2ab890d859b61636

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1433846 - Fix the comment for nsContentUtils::GetContextForContent().

GetCurrentDoc() is no longer used in the function since bug 1074738.

Review commit: https://reviewboard.mozilla.org/r/216172/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/216172/

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1433846 - Introduce nsContentUtils::GetPresShellForContent(const* nsIContent).

Review commit: https://reviewboard.mozilla.org/r/216174/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/216174/

Comment 3

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1433846 - Drop nsComputedDOMStyle::GetPresShellForContent(), use nsContentUtils::GetPresShellForContent().

Review commit: https://reviewboard.mozilla.org/r/216176/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/216176/

Comment 4

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8946185 [details]
Bug 1433846 - Fix the comment for nsContentUtils::GetContextForContent().

https://reviewboard.mozilla.org/r/216172/#review222196

Comment 5

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8946186 [details]
Bug 1433846 - Introduce nsContentUtils::GetPresShellForContent(const* nsIContent).

https://reviewboard.mozilla.org/r/216174/#review222198

Comment 6

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8946187 [details]
Bug 1433846 - Drop nsComputedDOMStyle::GetPresShellForContent(), use nsContentUtils::GetPresShellForContent().

https://reviewboard.mozilla.org/r/216176/#review222200

Comment 7

[Hiroyuki Ikezoe (:hiro)]

Thank you!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/239d24b07fe5
Fix the comment for nsContentUtils::GetContextForContent(). r=xidorn
https://hg.mozilla.org/integration/autoland/rev/d85600fe0ebc
Introduce nsContentUtils::GetPresShellForContent(const* nsIContent). r=xidorn
https://hg.mozilla.org/integration/autoland/rev/5a1d2718c712
Drop nsComputedDOMStyle::GetPresShellForContent(), use nsContentUtils::GetPresShellForContent(). r=xidorn

Comment 9

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/239d24b07fe5
https://hg.mozilla.org/mozilla-central/rev/d85600fe0ebc
https://hg.mozilla.org/mozilla-central/rev/5a1d2718c712