1433900 - Add automated test for "The location of a bookmark can be changed"

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, enhancement, P2)

Description

[Paul Silaghi, QA [:pauly]]

TestRail link: https://testrail.stage.mozaws.net/index.php?/cases/view/4149

Steps:
1. Launch Firefox and open a bookmark.
2. Enable the Bookmarks Toolbar and right-click on a bookmark, then select Properties.
3. Change the value of the Location field and either press enter or click Save.
4. Enable the Bookmarks Sidebar and right-click the same bookmark, then select Properties.
5. Change the value of the Location field and either press enter or click Save.

Expected results:
1. Firefox is successfully launched.
The selected bookmark is successfully loaded.
2. A dialog box is brought up showing the properties of the selected bookmark.
3. The URL of the bookmark is successfully modified.
4. A dialog box is brought up showing the properties of the selected bookmark.
5. The URL of the bookmark is successfully modified.

Comment 1

[Paul Silaghi, QA [:pauly]]

Attachment: browser_bookmark_change_location

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 8946603 [details] [diff] [review]
browser_bookmark_change_location

Review of attachment 8946603 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for this, just a couple of small issues to address.

::: browser/components/places/tests/browser/browser_bookmark_change_location.js
@@ +1,1 @@
> +/**

Please include a public domain license header, e.g. https://www.mozilla.org/en-US/MPL/headers/#pd-c

@@ +72,5 @@
> +});
> +
> +add_task(async function test_change_location_from_Sidebar() {
> +  let bookmarks = [];
> +  await PlacesUtils.bookmarks.fetch({ url: TEST_URL2 }, bm => bookmarks.push(bm));

We don't need to check the number of bookmarks here, so lets just simplify this to:

let bm = await PlacesUtils.bookmarks.fetch({ url: TEST_URL2 });

Comment 3

[Paul Silaghi, QA [:pauly]]

Attachment: browser_bookmark_change_location

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 8948352 [details] [diff] [review]
browser_bookmark_change_location

Review of attachment 8948352 [details] [diff] [review]:
-----------------------------------------------------------------

Look good. Thanks. r=Standard8

Comment 5

[Paul Silaghi, QA [:pauly]]

Try results:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=472a524b0774ba0abf42705034ed7c33623e9e74

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1c858a85df47
Add a test for checking the location of a bookmark can be changed. r=standard8

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/1c858a85df47