Open Bug 1433951 Opened 2 years ago Updated 2 years ago

Crash in mozilla::intl::LocaleService::GetRequestedLocales

Categories

(Toolkit :: General, defect, P3, critical)

59 Branch
x86
Windows
defect

Tracking

()

Tracking Status
firefox-esr52 --- unaffected
firefox58 --- unaffected
firefox59 --- fix-optional
firefox60 --- ?

People

(Reporter: philipp, Unassigned)

References

Details

(Keywords: crash, regression)

Crash Data

This bug was filed from the Socorro interface and is
report bp-18899c75-689c-43ac-ae6b-0e5350180129.
=============================================================

Top 10 frames of crashing thread:

0 xul.dll mozilla::intl::LocaleService::GetRequestedLocales intl/locale/LocaleService.cpp:964
1 xul.dll NS_InvokeByIndex xpcom/reflect/xptcall/md/win32/xptcinvoke_asm_x86_msvc.asm:54
2 xul.dll XPCWrappedNative::CallMethod js/xpconnect/src/XPCWrappedNative.cpp:1234
3 xul.dll XPC_WN_CallMethod js/xpconnect/src/XPCWrappedNativeJSOps.cpp:929
4 xul.dll js::InternalCallOrConstruct js/src/vm/Interpreter.cpp:473
5 xul.dll InternalCall js/src/vm/Interpreter.cpp:522
6 xul.dll Interpret js/src/vm/Interpreter.cpp:3096
7 xul.dll js::RunScript js/src/vm/Interpreter.cpp:423
8 xul.dll js::InternalCallOrConstruct js/src/vm/Interpreter.cpp:495
9 xul.dll InternalCall js/src/vm/Interpreter.cpp:522

=============================================================

crashes with this signature from a handful of installations so far start showing up on firefox desktop during the 59.0b cycle. they are all from 32bit installations on windows and apparently during startup of firefox.
It seems to be around https://hg.mozilla.org/mozilla-central/file/f84c3854510e/intl/locale/LocaleService.cpp#l957 - my only guess is the race condition between Prefs initialization and LocaleService initialization (initially triggered by XPCShell initialization.
(In reply to Zibi Braniecki [:gandalf][:zibi] from comment #1)
> It seems to be around
> https://hg.mozilla.org/mozilla-central/file/f84c3854510e/intl/locale/
> LocaleService.cpp#l957 - my only guess is the race condition between Prefs
> initialization and LocaleService initialization (initially triggered by
> XPCShell initialization.

Are you able to spend a bit more time looking into this?
Flags: needinfo?(gandalf)
I'm not skilled with C++ enough to be able to debug a crash I cannot reproduce :( Jonathan - is that something you may be able to help with?
Flags: needinfo?(gandalf) → needinfo?(jfkthame)
I don't see any obvious reason for this. It looks like a write to an almost-nullptr address (always 0x0000000b), which makes no sense to me unless the caller of LocaleService::GetRequestedLocales hasn't set up its (outparam) arguments properly. But if that XPCOM code were fundamentally broken, surely nothing would ever work...

Sorry, no help here. :(
Flags: needinfo?(jfkthame)
Very low crash volume for only a few installations. We could still take a patch for 60 if anyone figures out the issue.
Priority: -- → P3
You need to log in before you can comment on or make changes to this bug.