Closed Bug 1434011 Opened 7 years ago Closed 7 years ago

automatic signoff is broken when a user holds multiple roles and only one of them is required

Categories

(Release Engineering Graveyard :: Applications: Balrog (backend), enhancement, P1)

Product:
Release Engineering Graveyard
Component:
Applications: Balrog (backend)
Type:
enhancement

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: bhearsum, Assigned: abtcolns)

References

Details

While releases today I noticed that changes that I scheduled through the UI were not automatically signed off on. This is supposed to happen provided that the user holds one (and only one) of the Required Signoffs roles. The only remotely recent change we had to this logic was https://github.com/mozilla/balrog/commit/a994adddb16160908a06053daceb56bd9cc6a77d#diff-7c2c8a646f34fec41c773940931bf694 - which was supposed to add support for auto signing off on edits to Scheduled Changes. It's possible that it broken auto signoff for newly created changes.
Assignee: nobody → collins.abitekaniza
I just realized this is a bit more limited in scope - autosignoff is only broken when a user holds more than one role, and only one of the roles they require is part of the Required Signoffs. Eg: * Autosignoff should work if a change requires "relman" and "releng", and the user holds "releng" and "tb-releng" (it should signoff as "releng") * Autosignoff should not work if a change requires "releng" and "tb-releng", and the users holds "releng" and "tb-releng" (we cannot accurately guess which role the user wanted to signoff with).
Summary: automatic signoff is broken → automatic signoff is broken when a user holds multiple roles and only one of them is required
(In reply to Ben Hearsum (:bhearsum) from comment #1) > I just realized this is a bit more limited in scope - autosignoff is only > broken when a user holds more than one role, and only one of the roles they > require is part of the Required Signoffs. Eg: > * Autosignoff should work if a change requires "relman" and "releng", and > the user holds "releng" and "tb-releng" (it should signoff as "releng") > * Autosignoff should not work if a change requires "releng" and "tb-releng", > and the users holds "releng" and "tb-releng" (we cannot accurately guess > which role the user wanted to signoff with). Thanks, this now provides a more clear understanding of the issue.
Commit pushed to master at https://github.com/mozilla/balrog https://github.com/mozilla/balrog/commit/c847a51aee23f5ea9537a0339816777f5b887f55 bug 1434011: Automatic signoff is broken when a user holds multiple roles and only one of them is required (#466). r=bhearsum
Depends on: 1447753
In production.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Product: Release Engineering → Release Engineering Graveyard
You need to log in before you can comment on or make changes to this bug.