1434035 - stylo: ship system add-on to disable Stylo for Outlook and Hotmail

Status: RESOLVED WORKSFORME

(Core :: CSS Parsing and Computation, enhancement, P1)

Description

[Chris Peterson [:cpeterson]]

We need to ship a system add-on to temporarily disable Stylo for Outlook and Hotmail. We have an example Stylo system add-on in bug 1407911 that will need to be updated to block Outlook and Hotmail domains, re-signed, and tested.

layout.css.stylo-blocklist.enabled => true

layout.css.stylo-blocklist.blocked_domains => live.com,office365.com

Comment 1

[Bobby Holley (:bholley)]

Hm, why did this only show up in 58?

Comment 2

[[:philipp]]

stylo bug 1428164 (landed in 58) has regressed the behaviour on the site

Comment 3

[:Felipe Gomes (needinfo for replies!)]

Attachment: unsigned.xpi

Here's an untested, unsigned XPI for this. We need to:

- Sign it (:wezhou, can you do it?)

- Find clear steps to reproduce the breakage on Outlook/Hotmail so that QA can verify that it fixes the problem

Comment 4

[:Felipe Gomes (needinfo for replies!)]

(In reply to :Felipe Gomes (needinfo me!) from comment #3)
> - Find clear steps to reproduce the breakage on Outlook/Hotmail so that QA
> can verify that it fixes the problem

Do you know how to test this, Chris? Is an account needed?

Comment 5

[Chris Peterson [:cpeterson]]

Microsoft suggests that we also disable Stylo for outlook.com and outlook.office.com. So the list of domains in the layout.css.stylo-blocklist.blocked_domains pref should be "live.com,office365.com,outlook.com,outlook.office.com".

Comment 6

[jscher2000]

(In reply to Chris Peterson [:cpeterson] from comment #5)
> Microsoft suggests that we also disable Stylo for outlook.com and
> outlook.office.com. So the list of domains in the
> layout.css.stylo-blocklist.blocked_domains pref should be
> "live.com,office365.com,outlook.com,outlook.office.com".

The blocklist function does not work with full host names like outlook.office.com in my tests, so I suggest:

"live.com,office365.com,outlook.com,office.com"

Comment 7

[jscher2000]

(In reply to :Felipe Gomes (needinfo me!) from comment #4)
> (In reply to :Felipe Gomes (needinfo me!) from comment #3)
> > - Find clear steps to reproduce the breakage on Outlook/Hotmail so that QA
> > can verify that it fixes the problem
> 
> Do you know how to test this, Chris? Is an account needed?

This was my testing method; it is quickest if you have a dozen+ messages in the Inbox with long subject lines.

(1) Ensure the Reading Pane is set to hidden in Display settings.

(2) Open the first item in the Inbox in place (single click, not double-click to launch a new window) and use the mouse wheel to scroll up and down while the mouse is positioned over the (hidden) subject column of the Inbox. Should be normal. When hovering the mouse pointer over a link, cursor will be a pointer, not an arrow. Close the message by pressing the Esc key.

(3) Repeat with the second through fifth messages in the Inbox. Note that in broken conditions, the message list will appear scrolled when you Esc from the displayed message.

BUGGED: Scroll wheel should not work unless you position the pointer past the subject column or over a blank part of the subject or sender name column. When hovering a link that lines up over subject or sender name text, cursor will be an arrow instead of a pointer.

NORMAL: See #2.

You do need an account for that.

Comment 8

[:Felipe Gomes (needinfo for replies!)]

Attachment: unsigned-new.xpi

I included the new domains, and made a change to use default prefs instead of normal prefs. Assuming that the 58.0.2 dot release includes a fix for this problem, this version is nicer in that it won't need any follow-up to clean-up the prefs later.


Let's get this system add-on signed to test it

Comment 9

[:wezhou]

Attachment: signed.8946785.xpi

Signed file attached. Please test.

Comment 10

[:Felipe Gomes (needinfo for replies!)]

Thanks. I verified it locally and set up a test server so that QA can test.

Steps for testing:

- Using Firefox 58 with a fresh profile:

  - set extensions.logging.enabled to true
  - set devtools.chrome.enabled to true
  - set extensions.systemAddon.update.url to "https://felipc.github.io/styloblocklist/update.xml"  (without the quotes)

- Verify that the pref `layout.css.stylo-blocklist.blocked_domains` is empty
- Verify that the pref `layout.css.stylo-blocklist.enabled` is false

- Verify that the bug can be reproduced

- Now trigger an addon update check with this snippet in the browser console: https://wiki.mozilla.org/Add-ons/Hotfix#Triggering_the_update_check

- After the logging in the browser console stops, verify if the addon worked:

 - check that the pref layout.css.stylo-blocklist.blocked_domains was changed to:
   live.com,office365.com,outlook.com,office.com

 - check that the pref layout.css.stylo-blocklist.blocked_domains was changed to true

 - check that in about:support, the system addon "Update Stylo Blocklist" appears in the "Features" section

 - restart the browser and check that the bug can no longer be reproduced

Comment 11

[:Felipe Gomes (needinfo for replies!)]

jscher2000, since you can reliably reproduce the bug, would you be able to run through the steps above to check if the system addon correctly blocks stylo on that page (thus preventing the bug from happening)?

Comment 12

[jscher2000]

Hi Felipe, 

- Verify that the bug can be reproduced

BUGGED on https://outlook.live.com/owa/

- After the logging in the browser console stops, verify if the addon worked:

 - check that the pref layout.css.stylo-blocklist.blocked_domains was changed to:
   live.com,office365.com,outlook.com,office.com

YES

 - check that the pref layout.css.stylo-blocklist.blocked_domains was changed to true

YES 

 - check that in about:support, the system addon "Update Stylo Blocklist" appears in the "Features" section

YES

 - restart the browser and check that the bug can no longer be reproduced

GOOD on https://outlook.live.com/owa/

GOOD on https://outlook.office.com/owa/

GOOD on https://outlook.office365.com/owa/

Comment 13

[:Felipe Gomes (needinfo for replies!)]

Awesome! Thanks a lot for testing :)

Comment 14

[Chris Peterson [:cpeterson]]

Our current plan is to ship this Outlook fix in a Firefox 58.0.2 dot release (hopefully next week) instead of rushing the system add-on out this week.

Because of the way the system add-on would have worked, it would only fix the bug for users on Microsoft's outlook.com/etc domains, not any of the enterprise users with their on-premise Outlook websites. The system add-on fix also introduced some risk because we would be re-activating Firefox's pre-Quantum CSS code, which might reveal new surprising bugs with Outlook. Better to ship a safer fix for everyone next week.