1434050 - Inline report phishing overlay

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, enhancement, P3)

Description

[Brendan Dahl [:bdahl]]

report-phishing-overlay.xul is only used in browser.xul and should be inlined or included with the preprocessor.

Comment 1

[Brendan Dahl [:bdahl]]

Attachment: Bug 1434050 - Inline phishing overlay into the browser.

The phishing overlay was only used in one place and could be inlined. This
was slightly less straightforward as the original overlay was used on
browser.xul, but the elements it overlayed are defined in include files and
in another overlay (baseMenuOverlay.xul). Since baseMenuOverlay.xul is used
by other windows, the "hidden" attribute had to be added to the phishing
menuitems so they didn't show up in the other windows e.g. places.

Review commit: https://reviewboard.mozilla.org/r/216800/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/216800/

Comment 2

[François Marier [:francois]]

Redirecting the review to Johann since I'm not comfortable enough in XUL to review this.

Comment 3

[Johann Hofmann [:johannh]]

Comment on attachment 8946944 [details]
Bug 1434050 - Inline phishing overlay into the browser.

https://reviewboard.mozilla.org/r/216800/#review222672

I believe you also need to update https://searchfox.org/mozilla-central/rev/c56f656febb1aa58c72b218699e24a76425bd284/browser/base/content/moz.build#157

Comment 4

[Brendan Dahl [:bdahl]]

Comment on attachment 8946944 [details]
Bug 1434050 - Inline phishing overlay into the browser.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/216800/diff/1-2/

Comment 5

[Brendan Dahl [:bdahl]]

Comment on attachment 8946944 [details]
Bug 1434050 - Inline phishing overlay into the browser.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/216800/diff/2-3/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/086ddee2bb4d
Inline phishing overlay into the browser. r=johannh

Comment 7

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/086ddee2bb4d