Replace [moz-collapsed] with [collapsed]

NEW
Unassigned

Status

enhancement
2 years ago
7 months ago

People

(Reporter: bgrins, Unassigned)

Tracking

(Blocks 2 bugs)

Firefox Tracking Flags

(Not tracked)

Details

I'd like to remove the extra selector in minimal-xul.css and there are a few usages in `suite/`. AFAICT these could be replaced directly with "collapsed": https://searchfox.org/comm-central/search?q=moz-collapsed&redirect=true.
'moz-collapsed' was introduced to temporarily collapse elements where the 'collapsed' attribute would be persisted. I don't know if it still serves that purpose in comm-central. Instead of the 'collapsed' attribute, you could also set style.visibility = "collapse".
(In reply to Dão Gottwald [::dao] from comment #1)
> 'moz-collapsed' was introduced to temporarily collapse elements where the
> 'collapsed' attribute would be persisted. I don't know if it still serves
> that purpose in comm-central. Instead of the 'collapsed' attribute, you
> could also set style.visibility = "collapse".

Didn't realize that, but if it's still needed for that purpose then another option would be to re-add the rule into a document sheet like global.css.
As far as I see it it is still used for this purpose. I am a bit swaped right now but maybe stefanh has some time to look at it.
:bgrins

All [moz-collapsed] need to Replace with [collapsed] in these files?
https://searchfox.org/comm-central/search?q=moz-collapsed&redirect=true


(In reply to Brian Grinstead [:bgrins] from comment #0)
> I'd like to remove the extra selector in minimal-xul.css and there are a few
> usages in `suite/`. AFAICT these could be replaced directly with
> "collapsed":
> https://searchfox.org/comm-central/search?q=moz-collapsed&redirect=true.
Flags: needinfo?(bgrinstead)
(In reply to Manish Kumar from comment #4)
> :bgrins
> 
> All [moz-collapsed] need to Replace with [collapsed] in these files?
> https://searchfox.org/comm-central/search?q=moz-collapsed&redirect=true
> 
> 
> (In reply to Brian Grinstead [:bgrins] from comment #0)
> > I'd like to remove the extra selector in minimal-xul.css and there are a few
> > usages in `suite/`. AFAICT these could be replaced directly with
> > "collapsed":
> > https://searchfox.org/comm-central/search?q=moz-collapsed&redirect=true.

As per Comment 3 it's possible the easier thing to do would be to add `[moz-collapsed="true"] { visibility: collapse; }` to a stylesheet that's loaded everywhere. Maybe communicator.css - not sure. Forwarding question to :frg.
Flags: needinfo?(bgrinstead) → needinfo?(frgrahl)
I am currently swamped because of other removals of code which is used in comm-central. If you need to remove it just do. Would be only one more breakage.
Flags: needinfo?(frgrahl)
I would say just move the rule to a shared CSS file as per Comment 5 to avoid extra unnecessary work
You need to log in before you can comment on or make changes to this bug.