[Xlib] Xlib/Xprint misses support for "symbol-fontspecific"

RESOLVED FIXED in mozilla1.0

Status

()

Core
XUL
P1
critical
RESOLVED FIXED
16 years ago
16 years ago

People

(Reporter: Roland Mainz, Assigned: Roland Mainz)

Tracking

Trunk
mozilla1.0
All
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

16 years ago
While comparing Xlib toolkit with GTK+ sources I found that the sources are not
completly in sync - there is one missing line which adds support for
"symbol-fontspecific" fonts.
(Assignee)

Comment 1

16 years ago
Taking myself...
Assignee: jaggernaut → Roland.Mainz
(Assignee)

Updated

16 years ago
Status: NEW → ASSIGNED
Priority: -- → P1
Target Milestone: --- → mozilla1.0
(Assignee)

Comment 2

16 years ago
Created attachment 83013 [details] [diff] [review]
Patch for 2002-05-08-08-trunk
(Assignee)

Comment 3

16 years ago
Requesting r=/sr= ...
Keywords: patch, review
(Assignee)

Updated

16 years ago
Blocks: 79119

Comment 4

16 years ago
Comment on attachment 83013 [details] [diff] [review]
Patch for 2002-05-08-08-trunk

r=pete.zha@sun.com
Attachment #83013 - Flags: review+

Comment 5

16 years ago
Comment on attachment 83013 [details] [diff] [review]
Patch for 2002-05-08-08-trunk

sr=attinasi (is there a testcase that shows that this actually fixes
something?)
Attachment #83013 - Flags: superreview+
(Assignee)

Comment 6

16 years ago
Requesting a= for 1.0-branch...
Keywords: approval
(Assignee)

Comment 7

16 years ago
Marc Attinasi asked (in reviewers@mozilla.org):
> Is there a testcase or URL to show that this actually fixes something?

Well, it would be difficult to create an exact testcase (we may employ Xnest (a
Xserver which displays using a X window) for such tests :) - you have to make
sure that there is really no other font available which could be used instead
(since the font system tried to be "smart" and searches other fonts for a
matching glyph if it cannot get one using this line of code).
Mhhh, maybe we should think about a testsuite which use a Xnest-based
scripts for such tasks...
Comment on attachment 83013 [details] [diff] [review]
Patch for 2002-05-08-08-trunk

a=rjesup@wgate.com (make sure it's in trunk too)
Attachment #83013 - Flags: approval+
patch checked into branch, still needs to go into trunk
Keywords: fixed1.0.0
Fixed on trunk
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.