143413 - [Xlib] Xlib/Xprint misses support for "symbol-fontspecific"

Status: RESOLVED FIXED

(Core :: XUL, defect, P1)

Description

[Roland Mainz]

While comparing Xlib toolkit with GTK+ sources I found that the sources are not
completly in sync - there is one missing line which adds support for
"symbol-fontspecific" fonts.

Comment 1

[Roland Mainz]

Taking myself...

Comment 2

[Roland Mainz]

Attachment: Patch for 2002-05-08-08-trunk

Comment 3

[Roland Mainz]

Requesting r=/sr= ...

Comment 4

[Pete Zha]

Comment on attachment 83013 [details] [diff] [review]
Patch for 2002-05-08-08-trunk

r=[e-mail]

Comment 5

[Marc Attinasi]

Comment on attachment 83013 [details] [diff] [review]
Patch for 2002-05-08-08-trunk

sr=attinasi (is there a testcase that shows that this actually fixes
something?)

Comment 6

[Roland Mainz]

Requesting a= for 1.0-branch...

Comment 7

[Roland Mainz]

Marc Attinasi asked (in [e-mail]):
> Is there a testcase or URL to show that this actually fixes something?

Well, it would be difficult to create an exact testcase (we may employ Xnest (a
Xserver which displays using a X window) for such tests :) - you have to make
sure that there is really no other font available which could be used instead
(since the font system tried to be "smart" and searches other fonts for a
matching glyph if it cannot get one using this line of code).
Mhhh, maybe we should think about a testsuite which use a Xnest-based
scripts for such tasks...

Comment 8

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 83013 [details] [diff] [review]
Patch for 2002-05-08-08-trunk

a=[e-mail] (make sure it's in trunk too)

Comment 9

[Randell Jesup [:jesup] (needinfo me)]

patch checked into branch, still needs to go into trunk

Comment 10

[Randell Jesup [:jesup] (needinfo me)]

Fixed on trunk