Closed
Bug 1434151
Opened 7 years ago
Closed 7 years ago
Inline certificate viewer XUL overlays
Categories
(Core :: Security: PSM, enhancement)
Core
Security: PSM
Tracking
()
RESOLVED
FIXED
mozilla60
Tracking | Status | |
---|---|---|
firefox60 | --- | fixed |
People
(Reporter: bdahl, Assigned: bdahl)
References
Details
Attachments
(1 file)
These overlays are also only used once:
chrome://pippki/content/certDump.xul
chrome://pippki/content/OrphanOverlay.xul
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8946529 [details]
Bug 1434151 - Inline and remove the various certificate viewer overlays.
https://reviewboard.mozilla.org/r/216548/#review222804
Looks good - just some documentation comments.
::: commit-message-c0f08:1
(Diff revision 1)
> +Bug 1434151 - Inline and remove the various certificate viewer overlays. r?keeler
Looks like there is some documentation referencing certDump.xul and viewCertDetails.xul in security/manager/pki/resources/content/certViewer.js - if you could update that, that would be great.
::: commit-message-c0f08:3
(Diff revision 1)
> +Bug 1434151 - Inline and remove the various certificate viewer overlays. r?keeler
> +
> +This is part of the work to remove XUL overlays. All of these overlays are
truncated commit message?
Attachment #8946529 -
Flags: review?(dkeeler) → review+
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Pushed by bdahl@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/33e7010243bf
Inline and remove the various certificate viewer overlays. r=keeler
Comment 6•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in
before you can comment on or make changes to this bug.
Description
•