Closed Bug 1434163 Opened 3 years ago Closed 3 years ago
Make all ns
IURI attributes readonly
No description provided.
Comment on attachment 8946535 [details] Bug 1434163 - Make all nsIURI attributes readonly https://reviewboard.mozilla.org/r/216554/#review222432 ::: netwerk/base/nsIURI.idl:140 (Diff revision 1) > - attribute AUTF8String password; > + readonly attribute AUTF8String password; > > /** > * The host:port (or simply the host, if port == -1). > * > * If this attribute is set to a value that only has a host part, the port it can no longer be set, this comment should probably be on the mutator? ::: netwerk/test/gtest/TestStandardURL.cpp:13 (Diff revision 1) > #include "nsPrintfCString.h" > #include "nsComponentManagerUtils.h" > #include "nsIURIMutator.h" > +#define protected public > +#include "../../base/nsStandardURL.h" > +using mozilla::net::nsStandardURL; wow! that's a *HACK* :D you should at least #undef it :))) can't this somehow be achieved by deriving from nsStandardURL and 'public: using blabla' ? nsStandardURL is not marked final (but maybe should be....) other trick could be to have a predeclared friend class that will be implemented here OTOH, it's just a test and if it builds on all platforms then why not take this...
Attachment #8946535 - Flags: review?(honzab.moz) → review+
Hmm, a few methods are become private here, like SetSpecInternal().
Any ETA for landing this?
I was thinking of landing it today or tomorrow, after a final try run.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/74fc20523198 Make all nsIURI attributes readonly r=mayhemer
We were sort of hoping this would have qualified as a "risky patch or a large patch" that would be subject to the March 1 code freeze for Firefox 60 that was announced on m.d.platform. I guess not :(
The risky one was bug 1433958 which landed on 27th Feb. ;-)
You need to log in before you can comment on or make changes to this bug.