Closed Bug 1434163 Opened 6 years ago Closed 6 years ago

Make all nsIURI attributes readonly

Categories

(Core :: Networking, defect, P2)

Product:
Core
Component:
Networking
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla60
Tracking Flags:
Tracking Status
firefox60 --- fixed

People

(Reporter: valentin, Assigned: valentin)

References

Details

(Whiteboard: [necko-triaged])

Attachments

(1 file)

Bug 1434163 - Make all nsIURI attributes readonly
59 bytes, text/x-review-board-request
mayhemer
: review+
Details 
      No description provided.
Comment on attachment 8946535 [details]
Bug 1434163 - Make all nsIURI attributes readonly

https://reviewboard.mozilla.org/r/216554/#review222432

::: netwerk/base/nsIURI.idl:140
(Diff revision 1)
> -    attribute AUTF8String password;
> +    readonly attribute AUTF8String password;
>  
>      /**
>       * The host:port (or simply the host, if port == -1).
>       *
>       * If this attribute is set to a value that only has a host part, the port

it can no longer be set, this comment should probably be on the mutator?

::: netwerk/test/gtest/TestStandardURL.cpp:13
(Diff revision 1)
>  #include "nsPrintfCString.h"
>  #include "nsComponentManagerUtils.h"
>  #include "nsIURIMutator.h"
> +#define protected public
> +#include "../../base/nsStandardURL.h"
> +using mozilla::net::nsStandardURL;

wow!  that's a *HACK* :D

you should at least #undef it :)))

can't this somehow be achieved by deriving from nsStandardURL and 'public: using blabla' ?

nsStandardURL is not marked final (but maybe should be....)

other trick could be to have a predeclared friend class that will be implemented here

OTOH, it's just a test and if it builds on all platforms then why not take this...
Attachment #8946535 - Flags: review?(honzab.moz) → review+
Hmm, a few methods are become private here, like SetSpecInternal().
Any ETA for landing this?
I was thinking of landing it today or tomorrow, after a final try run.
Pushed by valentin.gosu@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/74fc20523198
Make all nsIURI attributes readonly r=mayhemer
https://hg.mozilla.org/mozilla-central/rev/74fc20523198
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox60: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
We were sort of hoping this would have qualified as a "risky patch or a large patch" that would be subject to the March 1 code freeze for Firefox 60 that was announced on m.d.platform. I guess not :(
The risky one was bug 1433958 which landed on 27th Feb. ;-)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: