autoland's pingbacks to reviewboard are stuck in a 404 loop

RESOLVED FIXED

Status

defect
RESOLVED FIXED
a year ago
11 months ago

People

(Reporter: glob, Assigned: glob)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
> trying to post mozreview update to: https://reviewboard.mozilla.org/api/extensions/mozreview.extension.MozReviewExtension/autoland-request-updates/ for request: 45441
> Starting new HTTPS connection (1): reviewboard.mozilla.org
> "POST /api/extensions/mozreview.extension.MozReviewExtension/autoland-request-updates/ HTTP/1.1" 404 70
> failed: 404 - {"stat": "fail", "err": {"msg": "Object does not exist", "code": 100}}

i will investigate why this pingback is 404'ing

currently autoland stops processing the list of pending pingbacks at the first failure, and it treats 404 as a transient failure.  the end result is this 404 is being retried infinitely.  autoland should treat a 404 as a fatal error for that pingback, and move on to the next request.
(Assignee)

Comment 1

a year ago
here's the request:
> {"landed": true, "trysyntax": "try: -b do -p all -u all -t none", "result": "af6a04127bfb", "request_id": 45441, "rev": "5105ffc915ea5dfc7ec55479e9d99e34b9217ff7", "destination": "try", "tree": "gecko", "error_msg": ""}

it's missing from rb's mozreview_autolandrequest table, triggering the 404.  i don't see anything in the logs that indicate why this row is missing.
(Assignee)

Comment 2

a year ago
i've removed the row from autoland's MozreviewUpdate table, and the large pile of pingbacks stuck behind it were all successfully sent.  patch to rework 404 handling soon.
Comment hidden (mozreview-request)

Comment 4

a year ago
mozreview-review
Comment on attachment 8946544 [details]
autoland: treat a 404 from a pingback as a fatal error (bug 1434166)

https://reviewboard.mozilla.org/r/216562/#review222248
Attachment #8946544 - Flags: review?(gps) → review+

Comment 5

a year ago
Pushed by bjones@mozilla.com:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/6f75d61627ad
autoland: treat a 404 from a pingback as a fatal error r=gps
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
(Assignee)

Comment 6

a year ago
deployed to prod.
This same thing came up 4 months ago in Bug 1405126. No idea how these are failing to be saved in MozReview's DB...

Updated

11 months ago
Product: MozReview → Conduit
You need to log in before you can comment on or make changes to this bug.