1434202 - [Wayland] popups does not have transparent background

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P2)

Description

[Martin Stránský [:stransky] (ni? me)]

Popups (hamburger menu for instance) does not have transparent background, the shadows around them are rendered on solid background.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1434202 - [Wayland] Set popups as app paintable on Wayland as we paint them ourself there,

Review commit: https://reviewboard.mozilla.org/r/216612/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/216612/

Comment 2

[Jan Horak [:jhorak]]

Comment on attachment 8946585 [details]
Bug 1434202 - [Wayland] Set popups as app paintable on Wayland as we paint them ourself there,

https://reviewboard.mozilla.org/r/216612/#review222316

Comment 3

[Jan Horak [:jhorak]]

Comment on attachment 8946585 [details]
Bug 1434202 - [Wayland] Set popups as app paintable on Wayland as we paint them ourself there,

https://reviewboard.mozilla.org/r/216612/#review222318

::: widget/gtk/nsWindow.cpp:3793
(Diff revision 1)
>                  gint wmd = ConvertBorderStyles(mBorderStyle);
>                  if (wmd != -1)
>                    gdk_window_set_decorations(mGdkWindow, (GdkWMDecoration) wmd);
>              }
>  
> +            if (!mIsX11Display) {

Please doublecheck if tooltips also need this and file another bug if required.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4c2350c7909c
[Wayland] Set popups as app paintable on Wayland as we paint them ourself there, r=jhorak

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/4c2350c7909c