1434322 - 404 from Azure is unhandled when getting a nonexistent QueueWorker

Status: RESOLVED FIXED

(Taskcluster :: Services, defect)

Description

[Dustin J. Mitchell [:dustin] (he/him)]

https://sentry.prod.mozaws.net/operations/taskcluster-queue/issues/1509435/

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

{code: ResourceNotFound, headers: {accept: application/json;odata=fullmetadata, dataserviceversion: 3.0, x-ms-client-request-id: fast-azure-storage, x-ms-date: Tue, 30 Jan 2018 16:13:26 GMT, x-ms-version: 2014-02-14}, incidentId: 5dc00baa-bee9-441d-910d-9d69e98926c5, method: GET, path: /QueueWorkerType(PartitionKey='staging-aws',RowKey='gecko-1-b-linux'), payload: {"odata.error":{"code":"ResourceNotFound","message":{"lang":"en-US","value":"The specified resource does not exist.\nRequestId:a630e396-0002-0058-68e5-99beb8000000\nTime:2018-01-30T16:13:26.5223653Z"}}}, query: {timeout: 7}, retries: 0, statusCode: 404}

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

https://github.com/taskcluster/taskcluster-queue/pull/247

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/taskcluster/taskcluster-queue

https://github.com/taskcluster/taskcluster-queue/commit/9a7babd7199cf2ad45f128f624b06e8a7563bde7
Bug 1434322 - handle worker types not found

https://github.com/taskcluster/taskcluster-queue/commit/d0260a20e7d54945848dc24c4ad2226893279648
Merge pull request #247 from djmitche/bug1434322

Bug 1434322 - handle worker types not found

Comment 4

[[github robot]]

Commit pushed to master at https://github.com/taskcluster/taskcluster-queue

https://github.com/taskcluster/taskcluster-queue/commit/edf512f8158cb965a988572f18fee0f6fab690ba
Bug 1434322 - create provisioners for other tests, too

Comment 5

[[github robot]]

Commit pushed to master at https://github.com/taskcluster/taskcluster-queue

https://github.com/taskcluster/taskcluster-queue/commit/ce102d8e19d9de3085e600114ef2bfa5c50a2bfa
Bug 1434322 - missed git-add

Comment 6

[Dustin J. Mitchell [:dustin] (he/him)]

Looks like the same issue exists in a few more places, notably getProvisioner.

  https://sentry.prod.mozaws.net/operations/taskcluster-queue/issues/643945/events/20197701/

Comment 7

[Dustin J. Mitchell [:dustin] (he/him)]

https://github.com/taskcluster/taskcluster-queue/pull/260

Comment 8

[[github robot]]

Commits pushed to master at https://github.com/taskcluster/taskcluster-queue

https://github.com/taskcluster/taskcluster-queue/commit/802421ef0883865349994af29af234f57929493f
Bug 1434322 - Retry to claim all 30 tasks (fix flaky test)

Since claimTask uses a real Azure queue, sometimes the messages don't
arrive in time, so call claimTasks a few times until we get all 30..

https://github.com/taskcluster/taskcluster-queue/commit/50eafee62b1b454c47a9c267dccf98809251813e
Bug 1434322 - Refactor worker info tests

Use common object-creation helpers

https://github.com/taskcluster/taskcluster-queue/commit/8321592dba60036450d494dfe311109931cce8fb
Bug 1434322 - Return 404's, and ensure parent objects exist

Declaring a worker should also declare workerType and provisioner;
declaring a workerType should also delcare a provisioner.

https://github.com/taskcluster/taskcluster-queue/commit/7ed2624a0f0b5f82f513bdc603f166f5ab7e4972
Bug 1434322 - factor out upserting

https://github.com/taskcluster/taskcluster-queue/commit/0e9562aa158634ffcdb99510e3545ece954107aa
Merge pull request #259 from djmitche/bug1434322-b

Bug 1434322 - return 404's when appropriate and always upsert upstream objects