Closed
Bug 1434381
Opened 6 years ago
Closed 6 years ago
Inline layoutdebug-overlay.xul
Categories
(Core :: Layout, enhancement)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: bdahl, Assigned: bdahl)
References
Details
Attachments
(1 file)
layoutdebug-overlay.xul is only used once and can instead be conditionally included with the preprocessor.
|
Assignee | |
Comment 1•6 years ago
|
||
The layoutdebug-overlay has two entities in a DTD file. I can either 1) move them into browser.dtd or 2) keep them in a separate DTD file and then conditionally include the DTD file in browser-doctype.inc. Do you have a preference?
Flags: needinfo?(dbaron)
I have no preference.
Flags: needinfo?(dbaron)
| Comment hidden (mozreview-request) |
Is a MOZ_WIDGET_TOOLKIT != android ifdef meaningful in browser-menubar.inc?
Flags: needinfo?(bdahl)
| Comment hidden (mozreview-request) |
|
||
Comment 7•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8950748 [details] Bug 1434381 - Inline the layout debug overlay into browser menu bar. https://reviewboard.mozilla.org/r/219992/#review225884
Attachment #8950748 -
Flags: review?(dbaron) → review+
Pushed by bdahl@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/db67b849d3d0 Inline the layout debug overlay into browser menu bar. r=dbaron
|
||
Comment 9•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/db67b849d3d0
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
|
||
Comment 10•6 years ago
|
||
For future reference: these strings were not exposed to localization, they should have probably stayed like that (I guess hard coded in the XUL file at this point). It's not easy to tell, but the fact that the .dtd was in a path of its own is a tell.
You need to log in
before you can comment on or make changes to this bug.
Description
•