1434544 - [Wayland] Remote client fails to start when no profile name is given on command line

Status: RESOLVED FIXED

(Core Graveyard :: X-remote, defect, P2)

Description

[Martin Stránský [:stransky] (ni? me)]

$firefox url does not work for DBus remote as we don't have specified the profile name - StartRemoteClient() has an empty profile name. We can remove profile name from remote protocol or get the profile name somehow. 

It has to work with:

- default profile, created by FF at first start
- custom created profile is chosen at ProfileManager as a default.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1434544 - When launching remote instance without profile name search for already running firefox instances,

We don't have profile name available when running with default profile.
With this patch Firefox looks for existing DBus interfaces and tries to pick one
instead of creating a new instance.

Review commit: https://reviewboard.mozilla.org/r/217498/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/217498/

Comment 2

[Jan Horak [:jhorak]]

Comment on attachment 8947780 [details]
Bug 1434544 - When launching remote instance without profile name search for already running firefox instances,

https://reviewboard.mozilla.org/r/217498/#review225520

::: widget/xremoteclient/DBusRemoteClient.cpp:105
(Diff revision 1)
> +    if (!reply) {
> +      return false;
> +    }
> +
> +    char **interfaces;
> +    dbus_int32_t interfaceNum;

Please use interfaceNums to be more clear that it's count of interfaces.

::: widget/xremoteclient/DBusRemoteClient.cpp:123
(Diff revision 1)
> +        break;
> +      }
> +    }
> +    dbus_free_string_array(interfaces);
> +
> +    return (i && i != interfaceNum);

I would rather check there if `aDestinationName` is not empty string there rather than checking `i` var, because what actually matters there is non empty aDestinationName value, right?

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 8947780 [details]
Bug 1434544 - When launching remote instance without profile name search for already running firefox instances,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/217498/diff/1-2/

Comment 4

[Jan Horak [:jhorak]]

Comment on attachment 8947780 [details]
Bug 1434544 - When launching remote instance without profile name search for already running firefox instances,

https://reviewboard.mozilla.org/r/217498/#review225566

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1b0fa4897edc
When launching remote instance without profile name search for already running firefox instances, r=jhorak

Comment 6

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/1b0fa4897edc

Comment 7

[Francois Guerraz]

Is this really fixed? I still have to specify the profile on the command line of my .desktop file for FF as a default browser so that links open in the existing session on Wayland.