[Wayland] Remote client fails to start when no profile name is given on command line

RESOLVED FIXED in Firefox 60

Status

()

P2
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: stransky, Assigned: stransky)

Tracking

(Blocks: 1 bug)

Trunk
mozilla60
Points:
---

Firefox Tracking Flags

(firefox60 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
$firefox url does not work for DBus remote as we don't have specified the profile name - StartRemoteClient() has an empty profile name. We can remove profile name from remote protocol or get the profile name somehow. 

It has to work with:

- default profile, created by FF at first start
- custom created profile is chosen at ProfileManager as a default.
Comment hidden (mozreview-request)

Comment 2

a year ago
mozreview-review
Comment on attachment 8947780 [details]
Bug 1434544 - When launching remote instance without profile name search for already running firefox instances,

https://reviewboard.mozilla.org/r/217498/#review225520

::: widget/xremoteclient/DBusRemoteClient.cpp:105
(Diff revision 1)
> +    if (!reply) {
> +      return false;
> +    }
> +
> +    char **interfaces;
> +    dbus_int32_t interfaceNum;

Please use interfaceNums to be more clear that it's count of interfaces.

::: widget/xremoteclient/DBusRemoteClient.cpp:123
(Diff revision 1)
> +        break;
> +      }
> +    }
> +    dbus_free_string_array(interfaces);
> +
> +    return (i && i != interfaceNum);

I would rather check there if `aDestinationName` is not empty string there rather than checking `i` var, because what actually matters there is non empty aDestinationName value, right?
Attachment #8947780 - Flags: review?(jhorak) → review-
Comment hidden (mozreview-request)

Comment 4

a year ago
mozreview-review
Comment on attachment 8947780 [details]
Bug 1434544 - When launching remote instance without profile name search for already running firefox instances,

https://reviewboard.mozilla.org/r/217498/#review225566
Attachment #8947780 - Flags: review?(jhorak) → review+

Comment 5

a year ago
Pushed by stransky@redhat.com:
https://hg.mozilla.org/integration/autoland/rev/1b0fa4897edc
When launching remote instance without profile name search for already running firefox instances, r=jhorak

Comment 6

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/1b0fa4897edc
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox60: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.