1434574 - [Wayland] Build wayland with EGL backend

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement, P3)

Description

[Martin Stránský [:stransky] (ni? me) (PTO till Feb 21)]

We need to build wayland enabled builds with EGL backend as GLX can't be used with Wayland.

Comment 1

[Martin Stránský [:stransky] (ni? me) (PTO till Feb 21)]

Attachment: Bug 1434574 - Build wayland with EGL OpenGL backend,

Review commit: https://reviewboard.mozilla.org/r/216866/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/216866/

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 8947071 [details]
Bug 1434574 - Build wayland with EGL OpenGL backend,

https://reviewboard.mozilla.org/r/216866/#review222862

::: gfx/gl/moz.build:18
(Diff revision 1)
>  elif CONFIG['MOZ_WIDGET_TOOLKIT'] == 'uikit':
>      gl_provider = 'EAGL'
> +if CONFIG['MOZ_WAYLAND']:
> +    gl_provider = 'EGL'
>  elif 'gtk' in CONFIG['MOZ_WIDGET_TOOLKIT']:
>      if CONFIG['MOZ_EGL_XRENDER_COMPOSITE']:

seems like you could add the condition here instead.

Comment 3

[Martin Stránský [:stransky] (ni? me) (PTO till Feb 21)]

Comment on attachment 8947071 [details]
Bug 1434574 - Build wayland with EGL OpenGL backend,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/216866/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/232be6a41577
Build wayland with EGL OpenGL backend, r=glandium

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/232be6a41577

Comment 6

[Fadi R]

Do we need to use: ac_add_options --with-gl-provider=EGL if we apply this patch?

Comment 7

[Martin Stránský [:stransky] (ni? me) (PTO till Feb 21)]

(In reply to Fadi R from comment #6)
> Do we need to use: ac_add_options --with-gl-provider=EGL if we apply this
> patch?

EGL backend is enabled by default on Wayland build so you don't need to use this option.

Comment 8

[Fadi R]

Thank you!