Closed Bug 1434574 Opened 2 years ago Closed 2 years ago

[Wayland] Build wayland with EGL backend

Categories

(Firefox Build System :: General, enhancement, P3)

enhancement

Tracking

(firefox60 fixed)

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: stransky, Assigned: stransky)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

We need to build wayland enabled builds with EGL backend as GLX can't be used with Wayland.
Blocks: gem
See Also: → 788319
Comment on attachment 8947071 [details]
Bug 1434574 - Build wayland with EGL OpenGL backend,

https://reviewboard.mozilla.org/r/216866/#review222862

::: gfx/gl/moz.build:18
(Diff revision 1)
>  elif CONFIG['MOZ_WIDGET_TOOLKIT'] == 'uikit':
>      gl_provider = 'EAGL'
> +if CONFIG['MOZ_WAYLAND']:
> +    gl_provider = 'EGL'
>  elif 'gtk' in CONFIG['MOZ_WIDGET_TOOLKIT']:
>      if CONFIG['MOZ_EGL_XRENDER_COMPOSITE']:

seems like you could add the condition here instead.
Attachment #8947071 - Flags: review?(mh+mozilla) → review+
Pushed by stransky@redhat.com:
https://hg.mozilla.org/integration/autoland/rev/232be6a41577
Build wayland with EGL OpenGL backend, r=glandium
https://hg.mozilla.org/mozilla-central/rev/232be6a41577
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Do we need to use: ac_add_options --with-gl-provider=EGL if we apply this patch?
(In reply to Fadi R from comment #6)
> Do we need to use: ac_add_options --with-gl-provider=EGL if we apply this
> patch?

EGL backend is enabled by default on Wayland build so you don't need to use this option.
Thank you!
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.