Closed Bug 1434599 Opened 4 years ago Closed 4 years ago
Enable mochitest dom/serviceworkers/test/test
This test was disabled in bug 1433276.
The test is fine, the js error was due to the update event being received before starting to control any clients. The original version of the worker script would register .onupdatefound after the worker was activated.
Attachment #8947085 - Flags: review?(bkelly)
Comment on attachment 8947085 [details] [diff] [review] Enable test_workerupdatefoundevent.html. Review of attachment 8947085 [details] [diff] [review]: ----------------------------------------------------------------- Thanks! ::: dom/serviceworkers/test/mochitest.ini @@ +340,5 @@ > [test_update_missing_imported_script.html] > [test_workerUnregister.html] > [test_workerUpdate.html] > [test_workerupdatefoundevent.html] > +#skip-if = !e10s # Bug 1433276 Looks like you forgot to delete the line.
Attachment #8947085 - Flags: review?(bkelly) → review+
Attachment #8947085 - Attachment is obsolete: true
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/87ef5029dd10 Enable test_workerupdatefoundevent.html. r=bkelly
Backed out changeset 87ef5029dd10 (bug 1434599) for failing in dom/serviceworkers/test/test_workerupdatefoundevent.html on a CLOSED TREE Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=87ef5029dd107d0de4fbd9ff336128d0596a7dc2&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable&selectedJob=159595428 Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=159595428&repo=mozilla-inbound Backout push: https://hg.mozilla.org/integration/mozilla-inbound/rev/86d833310227b6d5590fc361adb5e88f9b4310d7
I think the problem is we don't wait for the iframe to load and become controlled. Thus, when the worker gets the updatefoundevent it might not have a controlled client to postMessage to.
Wait for client to load and assert it's controlled by the sw.
Attachment #8947122 - Attachment is obsolete: true
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/66a85897ecb2 Enable test_workerupdatefoundevent.html. r=bkelly
You need to log in before you can comment on or make changes to this bug.