Open
Bug 1434649
Opened 7 years ago
Updated 2 years ago
Push the worker script URL label frame even when the profiler is inactive
Categories
(Core :: Gecko Profiler, defect, P2)
Core
Gecko Profiler
Tracking
()
NEW
Tracking | Status | |
---|---|---|
firefox60 | --- | affected |
People
(Reporter: mstange, Unassigned)
Details
https://searchfox.org/mozilla-central/rev/c56f656febb1aa58c72b218699e24a76425bd284/dom/workers/RuntimeService.cpp#2840 :
> NS_IMETHODIMP
> WorkerThreadPrimaryRunnable::Run()
> {
> AUTO_PROFILER_LABEL_DYNAMIC_LOSSY_NSSTRING(
> "WorkerThreadPrimaryRunnable::Run", OTHER, mWorkerPrivate->ScriptURL());
AUTO_PROFILER_LABEL_DYNAMIC_LOSSY_NSSTRING only pushes an entry if the profiler is running at the time that this function is entered. That makes sense for functions that get called frequently and only have a short runtime, but it's not great for long-running functions like the DOM worker's primary thread runnable, which stays on the stack for the entire duration that that script is run on the worker thread. So if the worker thread starts before the profiler is started, its script URL will not show up in profiles.
Updated•6 years ago
|
Summary: Push the worker script URL pseudo stack frame even when the profiler is inactive → Push the worker script URL label frame even when the profiler is inactive
Updated•6 years ago
|
Priority: -- → P2
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•