Closed Bug 1434679 Opened 8 years ago Closed 6 years ago

Migrate from using jquery for next/previous job to a more React way

Categories

(Tree Management :: Treeherder: Frontend, enhancement, P1)

Product:
Tree Management
Component:
Treeherder: Frontend
Type:
enhancement

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: camd, Assigned: camd)

References

Details

Attachments

(1 file)

Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/5293
47 bytes, text/x-github-pull-request
Details | Review
This would include the next/previous for 'n' and 'p' keys as well as arrow keys. We should also investigate improving the "scroll selected job into view". It's also very jquery centric. There is an experimental ``Element.scrollIntoView()`` function that may be helpful here.
Blocks: treeherder-react
Blocks: 1492003
This could perhaps be done either with: * Document functions like ``querySelectorAll``, etc. * ReactJS with ReactDOM and props.children or another way if something better comes to mind. :)
No longer blocks: treeherder-react
Priority: -- → P3
Assignee: nobody → cdawson
Status: NEW → ASSIGNED
Priority: P3 → P1
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: