1434697 - Implement variation font support in the Android (gfxFT2Fonts) backend

Status: RESOLVED FIXED

(Core :: Graphics: Text, enhancement)

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: patch 1 - Cherry-pick commit 994eb2b34934bc5face9f83b2d3b12cf7a9262ab (fix for FreeType bug https://savannah.nongnu.org/bugs/index.php?52955) from upstream to our in-tree copy, pending a new FreeType release

Comment 2

[Jonathan Kew [:jfkthame]]

Attachment: patch 2 - Implement variation font support in the Android (gfxFT2Fonts) backend

Comment 3

[Lee Salzman [:lsalzman]]

Comment on attachment 8947196 [details] [diff] [review]
patch 2 - Implement variation font support in the Android (gfxFT2Fonts) backend

Unless I am missing something, it seems like this will leak the FT_Face. You instantiate it and then pass it to cairo_ft_font_face_create_for_ft_face, but Cairo won't touch that face since it doesn't own it. The UserFontData does not know about this particular FT_Face either, so it won't get around to ever releasing it.

Comment 4

[Jonathan Kew [:jfkthame]]

Ah - good catch, thanks. That does indeed look like a problem; will fix.

Comment 5

[Jonathan Kew [:jfkthame]]

Attachment: patch 2 - Implement variation font support in the Android (gfxFT2Fonts) backend

OK, this should avoid the FT_Face leakage.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/dfa38f0a4879
patch 1 - Cherry-pick commit 994eb2b34934bc5face9f83b2d3b12cf7a9262ab (fix for FreeType bug https://savannah.nongnu.org/bugs/index.php?52955) from upstream to our in-tree copy, pending a new FreeType release. r=lsalzman
https://hg.mozilla.org/integration/mozilla-inbound/rev/e9acc45d2463
patch 2 - Implement variation font support in the Android (gfxFT2Fonts) backend. r=lsalzman

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/dfa38f0a4879
https://hg.mozilla.org/mozilla-central/rev/e9acc45d2463