1434769 - Update Debugger Frontend v13

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement, P3)

Comment 1

[Jason Laster [:jlast]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a5066f79dea7840915d4c81e2ae2469da2ef6a23

Comment 2

[Jason Laster [:jlast]]

Attachment: release-13.patch

Comment 3

[Julian Descottes [:jdescottes]]

Comment on attachment 8947288 [details] [diff] [review]
release-13.patch

Review of attachment 8947288 [details] [diff] [review]:
-----------------------------------------------------------------

- Meta:
 - assigned, P3, enhancement, blocks meta: KO, added
 - commit message: OK
 - less than 20 commits: OK
- TRY
 - try run green: KO 1 unreported intermittent (460 bytes leak on dt7 linux debug)
 - try run has rebuild: KO
- Manual test
 - OK
- README review
 - compare link: OK
 - commit link: OK
 - version number: OK
- Properties file review
 - KO: wrong label, cherry pick bug?
- New files
 - KO: remove mochi_log.txt

::: devtools/client/debugger/new/test/mochitest/browser.ini
@@ +127,5 @@
>  [browser_dbg-sourcemaps-reload.js]
>  [browser_dbg-sourcemaps-reloading.js]
>  [browser_dbg-sourcemaps2.js]
>  [browser_dbg-sourcemaps3.js]
> +skip-if = true

We now have 6 tests with skip-if = true for the new debugger, which is more 10% of our mochitests. This needs to be addressed.

::: devtools/client/locales/en-US/debugger.properties
@@ +28,4 @@
>  # context menu to set a directory as root directory
>  setDirectoryRoot.label=Set directory root
>  setDirectoryRoot.accesskey=r
> +# LOCALIZATION NOTE (removeDirectoryRoot.label): This is the text that appears in the

The rebase of my PR got rid of one blank line above this one?

@@ +32,3 @@
>  # context menu to remove a directory as root directory
>  removeDirectoryRoot.label=Remove directory root
> +setDirectoryRoot.accesskey=d

This is the wrong key?

Looks like something went wrong with the cherry pick, since everything is OK on master :/

Comment 4

[Jason Laster [:jlast]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2b5e77f94ac993ff5264ba5fa963dbfe1dc608ee

new patch coming

Comment 5

[Jason Laster [:jlast]]

Attachment: release-13-1.patch

Comment 6

[Julian Descottes [:jdescottes]]

Comment on attachment 8947459 [details] [diff] [review]
release-13-1.patch

Review of attachment 8947459 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM but need to synchronize devtools/client/debugger/new/index.html first.

::: devtools/client/debugger/new/index.html
@@ +19,5 @@
>      <div id="mount"></div>
>      <script type="application/javascript"
>              src="chrome://devtools/content/shared/theme-switching.js"></script>
>      <script type="text/javascript">
> +      const { BrowserLoader } = Components.utils.import("resource://devtools/client/shared/browser-loader.js", {});

Mass refactor from https://bugzilla.mozilla.org/show_bug.cgi?id=1431533, needs to be synced first.

Comment 7

[Jason Laster [:jlast]]

Attachment: release-13-2.patch

Comment 8

[Julian Descottes [:jdescottes]]

Comment on attachment 8947482 [details] [diff] [review]
release-13-2.patch

Review of attachment 8947482 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Jason!

Comment 9

[Cristina Coroiu [:ccoroiu]]

There are conflicts while trying to land, please take a look and provide an updated patch.

Comment 10

[Julian Descottes [:jdescottes]]

Yet again a mass refactor, from Bug 1339461.

Comment 11

[Jason Laster [:jlast]]

Attachment: release-13-3.patch

Comment 12

[Jason Laster [:jlast]]

small sanity try run
https://treeherder.mozilla.org/#/jobs?repo=try&revision=557dfb3b58b214027b55b730c723008d8c883d08

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f812e5fec015
Update Debugger Frontend v13. r=jdescottes

Comment 14

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/f812e5fec015