Closed
Bug 1434769
Opened 7 years ago
Closed 7 years ago
Update Debugger Frontend v13
Categories
(DevTools :: Debugger, enhancement, P3)
DevTools
Debugger
Tracking
(firefox60 fixed)
RESOLVED
FIXED
Firefox 60
Tracking | Status | |
---|---|---|
firefox60 | --- | fixed |
People
(Reporter: jlast, Assigned: jlast)
References
Details
Attachments
(1 file, 3 obsolete files)
813.83 KB,
patch
|
jdescottes
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•7 years ago
|
||
Assignee | ||
Comment 2•7 years ago
|
||
Attachment #8947288 -
Flags: review?(jdescottes)
Updated•7 years ago
|
Assignee: nobody → jlaster
Blocks: debugger-bundle-updates
Severity: normal → enhancement
Status: NEW → ASSIGNED
Priority: -- → P3
Comment 3•7 years ago
|
||
Comment on attachment 8947288 [details] [diff] [review]
release-13.patch
Review of attachment 8947288 [details] [diff] [review]:
-----------------------------------------------------------------
- Meta:
- assigned, P3, enhancement, blocks meta: KO, added
- commit message: OK
- less than 20 commits: OK
- TRY
- try run green: KO 1 unreported intermittent (460 bytes leak on dt7 linux debug)
- try run has rebuild: KO
- Manual test
- OK
- README review
- compare link: OK
- commit link: OK
- version number: OK
- Properties file review
- KO: wrong label, cherry pick bug?
- New files
- KO: remove mochi_log.txt
::: devtools/client/debugger/new/test/mochitest/browser.ini
@@ +127,5 @@
> [browser_dbg-sourcemaps-reload.js]
> [browser_dbg-sourcemaps-reloading.js]
> [browser_dbg-sourcemaps2.js]
> [browser_dbg-sourcemaps3.js]
> +skip-if = true
We now have 6 tests with skip-if = true for the new debugger, which is more 10% of our mochitests. This needs to be addressed.
::: devtools/client/locales/en-US/debugger.properties
@@ +28,4 @@
> # context menu to set a directory as root directory
> setDirectoryRoot.label=Set directory root
> setDirectoryRoot.accesskey=r
> +# LOCALIZATION NOTE (removeDirectoryRoot.label): This is the text that appears in the
The rebase of my PR got rid of one blank line above this one?
@@ +32,3 @@
> # context menu to remove a directory as root directory
> removeDirectoryRoot.label=Remove directory root
> +setDirectoryRoot.accesskey=d
This is the wrong key?
Looks like something went wrong with the cherry pick, since everything is OK on master :/
Attachment #8947288 -
Flags: review?(jdescottes) → review-
Assignee | ||
Comment 4•7 years ago
|
||
Assignee | ||
Comment 5•7 years ago
|
||
Attachment #8947288 -
Attachment is obsolete: true
Attachment #8947459 -
Flags: review?(jdescottes)
Comment 6•7 years ago
|
||
Comment on attachment 8947459 [details] [diff] [review]
release-13-1.patch
Review of attachment 8947459 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM but need to synchronize devtools/client/debugger/new/index.html first.
::: devtools/client/debugger/new/index.html
@@ +19,5 @@
> <div id="mount"></div>
> <script type="application/javascript"
> src="chrome://devtools/content/shared/theme-switching.js"></script>
> <script type="text/javascript">
> + const { BrowserLoader } = Components.utils.import("resource://devtools/client/shared/browser-loader.js", {});
Mass refactor from https://bugzilla.mozilla.org/show_bug.cgi?id=1431533, needs to be synced first.
Attachment #8947459 -
Flags: review?(jdescottes) → review+
Assignee | ||
Comment 7•7 years ago
|
||
Attachment #8947459 -
Attachment is obsolete: true
Attachment #8947482 -
Flags: review?(jdescottes)
Comment 8•7 years ago
|
||
Comment on attachment 8947482 [details] [diff] [review]
release-13-2.patch
Review of attachment 8947482 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks Jason!
Attachment #8947482 -
Flags: review?(jdescottes) → review+
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Comment 9•7 years ago
|
||
There are conflicts while trying to land, please take a look and provide an updated patch.
Flags: needinfo?(jlaster)
Keywords: checkin-needed
Comment 10•7 years ago
|
||
Yet again a mass refactor, from Bug 1339461.
Assignee | ||
Comment 11•7 years ago
|
||
Attachment #8947482 -
Attachment is obsolete: true
Flags: needinfo?(jlaster)
Attachment #8947813 -
Flags: review?(jdescottes)
Assignee | ||
Comment 12•7 years ago
|
||
Updated•7 years ago
|
Attachment #8947813 -
Flags: review?(jdescottes) → review+
Comment 13•7 years ago
|
||
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f812e5fec015
Update Debugger Frontend v13. r=jdescottes
Comment 14•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•