1434803 - PeerConnectionImpl errors get swallowed in the binding layer in a bunch of cases

Status: RESOLVED FIXED

(Core :: WebRTC, defect, P2)

Description

[Boris Zbarsky [:bzbarsky]]

Patch coming up with an explanation in the commit message.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Properly propagate out errors from various PeerConnectionImpl methods

PeerConnectionImpl defines two versions of various fallible methods: a version
taking an ErrorResult argument, and a version returning nsresult.  The methods
were not marked fallible in the webidl, so the bindings called the
nsresult-returning version, but ignored the returned value.  As a result,
failures got swallowed instead of being propagated out.

The changes here annotate the relevant parts of the webidl as throwing, and
convert non-fallible methods to returning void to make infallibility clearer.

MozReview-Commit-ID: JU9NzmEf8FV

Comment 2

[Nils Ohlmeier [:drno]]

Comment on attachment 8947340 [details] [diff] [review]
Properly propagate out errors from various PeerConnectionImpl methods

Review of attachment 8947340 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fb0b7a29a7ec
Properly propagate out errors from various PeerConnectionImpl methods.  r=drno

Comment 4

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/fb0b7a29a7ec