1434804 - Setting volume to audible after auto-playing inaudible video makes video audible

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

Our blocking of autoplay of audible videos is trivial to defeat:

STR, create a web page that:
1. Load a video.
2. Set video.volume = 0, or video.mute = true
3. call video.play(). Under autoplay policy the video should play without user gesture as it's inaudible.
4. set video.volume = 1.0, or video.mute = false.
5. Voila! Audible video is auto playing.

We should probably check to see whether the media is allowed to autoplay audibly when setting volume!=0 or !muted and pause() the video if its not allowed.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Testcase - Mute/autoplay/unmute

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Testcase - volume=0,autoplay,volume=1

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

We should consider doing do the reverse too; if a video has an autoplay attribute and is audible and is subsequently muted, maybe we should start playback?

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Bug 1434804 - Test that setting a muted-autoplay media to audible pauses media.

Review commit: https://reviewboard.mozilla.org/r/226946/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/226946/

Comment 5

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Bug 1434804 - Pause autoplayed media if they become audible.

Review commit: https://reviewboard.mozilla.org/r/226948/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/226948/

Comment 6

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8958012 [details]
Bug 1434804 - Pause autoplayed media if they become audible.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/226948/diff/1-2/

Comment 7

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8958011 [details]
Bug 1434804 - Test that setting a muted-autoplay media to audible pauses media.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/226946/diff/1-2/

Comment 8

[u480271]

Comment on attachment 8958011 [details]
Bug 1434804 - Test that setting a muted-autoplay media to audible pauses media.

https://reviewboard.mozilla.org/r/226946/#review233006

Comment 9

[u480271]

Comment on attachment 8958012 [details]
Bug 1434804 - Pause autoplayed media if they become audible.

https://reviewboard.mozilla.org/r/226948/#review233010

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/09d7852a968d
Pause autoplayed media if they become audible. r=kamidphish
https://hg.mozilla.org/integration/autoland/rev/8ea5bbce1d95
Test that setting a muted-autoplay media to audible pauses media. r=kamidphish

Comment 11

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/09d7852a968d
https://hg.mozilla.org/mozilla-central/rev/8ea5bbce1d95