1434821 - "Search google for" to open in background when clicked while holding down Ctrl and in new windows when using Shift

Status: RESOLVED FIXED

(Firefox :: Menus, enhancement, P5)

Description

[In]

"Search google for" should open in background when clicked while holding down Ctrl.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

We added support for something similar with bug 1410900 where we allowed the cache to be skipped when reloading iframes.

We could add support for this too, though it is probably not high enough priority for staff to work on. Whoever works on this should include an automated test with it.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

This is the code that formats the string for the menuitem,
https://searchfox.org/mozilla-central/rev/f80722d4f3bfb722c5ec53880c4a7efb71285676/browser/base/content/nsContextMenu.js#1489-1515

This is the code that shows the menuitem,
https://searchfox.org/mozilla-central/rev/f80722d4f3bfb722c5ec53880c4a7efb71285676/browser/base/content/nsContextMenu.js#515-519

This is the markup for the menuitem as well as the oncommand handler which gets executed when the menuitem is clicked,
https://searchfox.org/mozilla-central/rev/f80722d4f3bfb722c5ec53880c4a7efb71285676/browser/base/content/browser-context.inc#311-312

This is the code that performs the search,
https://searchfox.org/mozilla-central/rev/f80722d4f3bfb722c5ec53880c4a7efb71285676/browser/base/content/browser.js#3800-3811

You would need to update the markup for the menuitem to pass in the event object to the code that performs the search and check if any modifier keys were pressed.

Comment 3

[Anwesh]

hey I don't quite understand this. Correct me If I am wrong.

I select some text -> Then highlight it -> Clicked plus holding down Ctrl -> Opens a new tab(or background? does that mean a new tab)

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

We can also add support for Shift, as bug 1436658 has requested.

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Anwesh from comment #3)
> hey I don't quite understand this. Correct me If I am wrong.
> 
> I select some text -> Then highlight it -> Clicked plus holding down Ctrl ->
> Opens a new tab(or background? does that mean a new tab)

You should select some text, right click on the selection, then while holding down Ctrl click on the "Search Google for ..." item. The label will be slightly different if you have a different default search engine configured.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months, so the assignee is being reset.

Comment 9

[Shane Hughes [:aminomancer]]

Seems to work for me