143486 - enter_bug.cgi: Using ?format=simple doesn't work

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Tobias Burnus]

It is now possible to use more than one format for enter_bug.cgi (bug 138903).
But here it doesn't work.
I traced it down to
  my $format = ValidateOutputFormat($::FORM{'format'}, "create");
is called.
This sets $scriptdir to "create". It works with "bug/create"

Patch to come.

Comment 1

[Tobias Burnus]

Attachment: Patch enter_bug.cgi to make it work with format

Comment 2

[Dave Miller [:justdave]]

Comment on attachment 83053 [details] [diff] [review]
Patch enter_bug.cgi to make it work with format

This looks like a side-effect of moving the template directory.  good catch.

But we don't need "create" in the list at all anymore.	They are all in the
bug/create directory.  let's remove "create" from the list.

Comment 3

[Dave Miller [:justdave]]

thought I reassigned there, guess I missed...

Comment 4

[Gervase Markham [:gerv]]

> It is now possible to use more than one format for enter_bug.cgi

Well, actually it's not, because the "simple" (Bugzilla Helper replacement)
template sitting on my hard drive hasn't been checked in yet :-) I hope to have
it up for review this weekend.

Gerv

Comment 5

[Tobias Burnus]

> But we don't need "create" in the list at all anymore. They are all in the
> bug/create directory.  let's remove "create" from the list.

I'm not sure how I have to understead it.

-my $format = ValidateOutputFormat($::FORM{'format'}, "create");
+my $format = ValidateOutputFormat($::FORM{'format'}, "create", "bug/create");

the second parameter is the $script
the third  parameter is the $subdir

and in global.pl:
  $subdir = $script if !defined($subdir);

I don't see another solution as done in attachment 83053 [details] [diff] [review].

> > It is now possible to use more than one format for enter_bug.cgi
> Well, actually it's not.
I ment my own create-simple.html.tmpl ;-)

Comment 6

[Dave Miller [:justdave]]

OK, maybe I misunderstood the parameters on that code...   Gerv?

Comment 7

[Gervase Markham [:gerv]]

Comment on attachment 83053 [details] [diff] [review]
Patch enter_bug.cgi to make it work with format

This is the right fix. At least, it makes my create-simple.html.tmpl work :-)

Gerv

Comment 8

[Gervase Markham [:gerv]]

Fixed on trunk and branch.

Checking in enter_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/enter_bug.cgi,v  <--  enter_bug.cgi
new revision: 1.67; previous revision: 1.66
done

Checking in enter_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/enter_bug.cgi,v  <--  enter_bug.cgi
new revision: 1.66.2.1; previous revision: 1.66
done

Gerv