Closed
Bug 1434888
Opened 6 years ago
Closed 5 years ago
The shortcut for the Accessibility tab doesn't work
Categories
(DevTools :: Accessibility Tools, defect)
DevTools
Accessibility Tools
Tracking
(firefox65 verified, firefox66 verified)
VERIFIED
FIXED
Firefox 66
People
(Reporter: cfat, Assigned: yzen)
References
()
Details
Attachments
(3 files)
764.93 KB,
image/gif
|
Details | |
47 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details | Review |
47 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details | Review |
[Affected versions]: - Nightly 59.0a1 [Affected Platforms]: - All Windows - All Mac - All Linux [Prerequisites]: - Have the latest try build 59.0a1 from (2018-01-05) installed [Steps to reproduce]: 1. Open the browser with the profile from prerequisites. 2. Open the Web Console (Ctrl+Shift+k) and click on the Toolbox Options button. 3. Click on the "Accessibility" checkbox from the Default Developer Tools section. 4. Press on Ctrl+Shift+z (Cmd+Opt+z) keys and observe what happens next. [Expected result]: - Accessibility tab is focused and displayed. [Actual result]: - Nothing happens, the Accessibility tab is not focused nor displayed. [Notes]: - Attached is a gif with the issue.
Assignee | ||
Comment 1•6 years ago
|
||
Will be fixed with the new build. NOTE: Shortcut is going to be updated to Cmd+Opt+A
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 2•6 years ago
|
||
Hi Yura, Tested this with the latest try build 60.0a1 (2018-02-13) and here are the results: - On Windows and Linux, the shortcut is "Ctrl"+"Shift"+"A", which opens the Add-ons Manager page (about:addons). Thereby, I recommend changing this with a shortcut that doesn't interfere with other functionalities. - On Mac OS, the shortcut is still "Cmd"+"Opt"+"z" and it still doesn't focus the Accessibility tab.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 3•6 years ago
|
||
Sounds good, I updated and put back to the "Z" as command key. Not pushed to try yet but will be fixed.
Status: REOPENED → RESOLVED
Closed: 6 years ago → 6 years ago
Resolution: --- → FIXED
Comment 4•6 years ago
|
||
Unfortunately the "Ctrl+Shift+Z" shrotcut is not working as expected on Windows and Linux. The shortcut works only if you previously opened the Web Console. After further investigation I have found that the "Ctrl+Shift+Z" shortcut is already used by Mozilla for "redo" option: https://developer.mozilla.org/en-US/docs/Tools/Keyboard_shortcuts However, on Mac OS the "Cmd+Opt+Z" shortcut for Accessibility works as expected.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Updated•6 years ago
|
Component: Developer Tools → Developer Tools: Accessibility Tools
Assignee | ||
Comment 5•6 years ago
|
||
I updated it to '0'
Comment 6•6 years ago
|
||
I have retested this issue using the latest Nightly try build (2018-03-01), but the shortcut is not working on Windows and Linux. If you press the "Ctrl+Shift+0" keyboard shortcut noting happens. However, it seems that on Mac Os the "Cmd+Opt+0" shortcut is working as expected.
Assignee | ||
Updated•6 years ago
|
Status: REOPENED → RESOLVED
Closed: 6 years ago → 6 years ago
Resolution: --- → DUPLICATE
Updated•6 years ago
|
Product: Firefox → DevTools
Assignee | ||
Updated•5 years ago
|
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Assignee | ||
Comment 8•5 years ago
|
||
MozReview-Commit-ID: HkL5dDfo0p9
Pushed by yura.zenevich@gmail.com: https://hg.mozilla.org/integration/autoland/rev/a412f6082597 set accessibility panel command key to Shift + F10. r=gl
Assignee | ||
Comment 10•5 years ago
|
||
Comment on attachment 9030310 [details] Bug 1434888 - set accessibility panel command key to Shift + F10. r=gl [Beta/Release Uplift Approval Request] Feature/Bug causing the regression: None User impact if declined: Keyboard users (including screen reader users) will not have a command key combination for the accessibility panel (already existing complaints over Twitter) Is this code covered by automated tests?: No Has the fix been verified in Nightly?: No Needs manual test from QE?: No If yes, steps to reproduce: List of other uplifts needed: None Risk to taking this patch: Low Why is the change risky/not risky? (and alternatives if risky): Just added a command key combination for the panel + updated the label. String changes made/needed: accessibility.tooltip3 in devtools/client/locales/en-US/startup.properties
Attachment #9030310 -
Flags: approval-mozilla-beta?
Comment 11•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a412f6082597
Status: REOPENED → RESOLVED
Closed: 6 years ago → 5 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
Updated•5 years ago
|
Assignee: nobody → yzenevich
Comment 12•5 years ago
|
||
NI Flod for approval on the string changes.
Flags: needinfo?(francesco.lodolo)
Assignee | ||
Comment 14•5 years ago
|
||
Ryan, can we hold off on uplifting it, there might be a conflict with the command key on windows (Shift + F10 triggers context menues). I'm gonna push a follow up to nightly that changes F10 to probably F12.
Flags: needinfo?(ryanvm)
Assignee | ||
Updated•5 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 16•5 years ago
|
||
MozReview-Commit-ID: JchHjW7nKkH
Comment 17•5 years ago
|
||
Pushed by yura.zenevich@gmail.com: https://hg.mozilla.org/integration/autoland/rev/0e8109eaef4b update accessibility panel command key from Shift + F10 to Shift + F12. r=gl,flod
Assignee | ||
Comment 18•5 years ago
|
||
Comment on attachment 9030736 [details] Bug 1434888 - update accessibility panel command key from Shift + F10 to Shift + F12. r=gl [Beta/Release Uplift Approval Request] Feature/Bug causing the regression: Bug 1434888 User impact if declined: Follow up to the original patch that fixes a collision of Shift + F12 combo on Windows Is this code covered by automated tests?: No Has the fix been verified in Nightly?: No Needs manual test from QE?: No If yes, steps to reproduce: List of other uplifts needed: None Risk to taking this patch: Low Why is the change risky/not risky? (and alternatives if risky): Updated a command key combination for the panel. String changes made/needed: accessibilityF12.commandkey in devtools/startup/locales/en-US/key-shortcuts.properties
Attachment #9030736 -
Flags: approval-mozilla-beta?
Comment 19•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/0e8109eaef4b
Status: REOPENED → RESOLVED
Closed: 5 years ago → 5 years ago
Resolution: --- → FIXED
Comment 21•5 years ago
|
||
Comment on attachment 9030310 [details] Bug 1434888 - set accessibility panel command key to Shift + F10. r=gl [Triage Comment] Adds a command key combination for accessing the accessibility panel. String changes approved by Flod. Approved for 65.0b5.
Flags: needinfo?(ryanvm)
Attachment #9030310 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Updated•5 years ago
|
Attachment #9030736 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Updated•5 years ago
|
Flags: qe-verify+
Comment 22•5 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/4a9792ce63e3 https://hg.mozilla.org/releases/mozilla-beta/rev/aea4a31fb8bb
status-firefox65:
--- → fixed
Comment 23•5 years ago
|
||
I have reproduced this issue using Firefox 64.0a1(2018.08.11) on Win 8.1 x64. I can confirm this issue is fixed, I verified using Firefox 65.0b5 and 66.0a1 on Win 8.1 x64, Mac OS X 10.10.5 and Ubuntu 16.04 x64.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in
before you can comment on or make changes to this bug.
Description
•