1434902 - e2e-tests home page tests probably broken

Status: RESOLVED FIXED

(Socorro :: General, task)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

I'm kind of skipping through code changes at the moment to try to land something soon that impacts another team.

In the process of doing that, I nixed the graph on the product home page.

The e2e-tests/pages/home_page.py::CrashStatsHomePage class seems to rely on graph loading:

https://github.com/mozilla-services/socorro/blob/37164e167d4160ca980bad88aba043cbf8c6ce8f/e2e-tests/pages/home_page.py#L21

Since the graph no longer exists, it's likely that class is busted now. That might affect test outcomes.

This bug covers figuring out which e2e-tests are now broken and fixing them accordingly.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

Grumpy: I don't understand why the code waits for the graph to load. I don't see any graph-related tests, but I might be missing something.

Can you or one of the QA folks who knows these tests better take a stab at updating these?

Comment 2

[Chris Hartjes [:grumpy][:chartjes]]

willkg -- I will take a look

Comment 3

[Chris Hartjes [:grumpy][:chartjes]]

willkg - in that particular test I commented out a line where it is waiting for the graph to load. I then ran the tests against staging and they all passed except for one:

[gw2] [ 96%] FAILED tests/test_search.py::TestSearchForSpecificResults::test_search_for_valid_signature

I will submit a PR for removing that line

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla-services/socorro

https://github.com/mozilla-services/socorro/commit/223e771382505e8d3e0cf2d6fcec39b61bf5dd2c
Fix bug 1434902: remove references to graph no longer being used on home
page

https://github.com/mozilla-services/socorro/commit/36492cafbd42967d829881f0b46218fed91da8c1
Merge pull request #4326 from chartjes/ch-remove-graph-references

Fix bug 1434902: Removes references to graph on the home page, which is no longer in use.