Closed
Bug 1434904
Opened 6 years ago
Closed 6 years ago
Remove dependency to testSize.html in test_elementsize.py
Categories
(Remote Protocol :: Marionette, enhancement, P3)
Tracking
(firefox60 fixed)
RESOLVED
FIXED
mozilla60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: whimboo, Assigned: iceman, Mentored)
References
Details
(Keywords: good-first-bug, Whiteboard: [lang=py])
User Story
For steps in how to get started please consult our documentation for new users: https://firefox-source-docs.mozilla.org/testing/marionette/marionette/NewContributors.html In the case of questions you can find us on IRC in the #ateam channel.
Attachments
(2 files)
The following test is using an external HTML testcase, which is simple enough to get integrated as data URL directly into the test. For Marionette unit tests we make use of the `inline` method. Here an example: https://dxr.mozilla.org/mozilla-central/rev/a928be5dacc3b544e29c0612b3f8cda6447df802/testing/marionette/harness/marionette_harness/tests/unit/test_typing.py#14 The same method should be applied to the following test: https://dxr.mozilla.org/mozilla-central/rev/default/testing/marionette/harness/marionette_harness/tests/unit/test_elementsize.py By adding as minimal necessary code from the following HTML testcase: https://dxr.mozilla.org/mozilla-central/rev/default/testing/marionette/harness/marionette_harness/www/testSize.html The HTML testcase should be deleted afterward.
|
||
Comment 2•6 years ago
|
||
Please go ahead and attach your patch.
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
Assignee | |
Comment 5•6 years ago
|
||
Hello, I'm attached my patch, I didn't hear Sabot's changes about 15 days. Anyway, if Sabot will decide to continue work on the bug, feel free to delete my patch.
|
|
||
Comment 6•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8951858 [details] Bug 1434904 - Remove dependency to testSize.html in test_elementsize.py https://reviewboard.mozilla.org/r/221144/#review227144
Attachment #8951858 -
Flags: review+
|
|
||
Comment 7•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8951859 [details] Bug 1434904 - Delete testSize.html test case https://reviewboard.mozilla.org/r/221150/#review227146
Attachment #8951859 -
Flags: review+
Pushed by atolfsen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/022b0205b80e Remove dependency to testSize.html in test_elementsize.py r=ato https://hg.mozilla.org/integration/autoland/rev/e1ac6bfbb020 Delete testSize.html test case r=ato
|
||
Comment 9•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/022b0205b80e https://hg.mozilla.org/mozilla-central/rev/e1ac6bfbb020
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
|
Reporter | |
Comment 10•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8951859 [details] Bug 1434904 - Delete testSize.html test case https://reviewboard.mozilla.org/r/221150/#review227252
Attachment #8951859 -
Flags: review?(hskupin)
|
|
Reporter | |
Updated•6 years ago
|
Attachment #8951858 -
Flags: review?(hskupin)
|
||
Updated•6 years ago
|
Assignee: nobody → mykhaylo.yusko
|
||
Updated•1 year ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•