1434918 - The "Edit" button should be changed to an "Add" button for empty "Top Sites"

Status: NEW

(Firefox :: New Tab Page, enhancement, P3)

Description

[Marius Coman [:mcoman], Ecosystem QA]

Attachment: rec of the issue.gif

[Notes]:
- Bug 1432899 changed the "Edit" button into an "Add" button and the "Edit" modal into the "Add" one. For the sake of consistency we should also change the placeholder button and the modal for empty Top Sites.

[Affected versions]:
- Nightly 60.0a1 Build ID 20180131220303

**[Affected Platforms]:**
- All Windows
- All Mac
- All Linux

[Prerequisites]:
- browser.newtabpage.activity-stream.enabled is set to true in about:config on a clean new profile.

[Steps to reproduce]:
1. Start the browser with the profile from prerequisites and open a new tab.
2. Hover an empty "Top Site" and observe the displayed button's icon.
3. Hover the button from the previous step and observe the displayed tooltip.
4. Click the button and observe the opened modal.

[Expected result]:
- Step 2: The "+" icon is displayed.
- Step 3: The "Add Top Site" tooltip is displayed.
- Step 4: The "New Top Site" modal is opened.

[Actual result]:
- Step 2: The "Pencil" icon is displayed.
- Step 3: The "Edit this site" tooltip is displayed.
- Step 4: The "Edit Top Site" modal is opened.

[Additional Notes]:
- Attached a screen recording of the issue.

Comment 1

[Ed Lee :Mardak]

Bug 1434372 changed the form's title and button to be "Add" related, but the tooltip was unchanged. It should be the same as the "Add" link/button:
  "edit_topsites_add_button_tooltip": "Add Top Site",

Comment 2

[Adrian Florinescu [:aflorinescu]]

Issue still valid on 91.0a1 20210701211644 Mac 11.04.