1434944 - Change crash annotations for bug 1399557 so that they can be converted into type-safe ones

Status: RESOLVED INVALID

(Toolkit :: Crash Reporting, defect)

Description

[Gabriele Svelto [:gsvelto]]

+++ This bug was initially created as a clone of Bug #1348273 +++

Bug 1399557 introduced a series of annotations within ipc/mscom/Interceptor.cpp which keys include the file name and line number. This makes it impossible to convert those calls for bug 1348273.

Comment 1

[Gabriele Svelto [:gsvelto]]

Aaron, since you wrote the patch you probably can tell me more about how the annotations in bug 1399557 were done that way. I would like to replace them with elements of the crash annotation list I wrote for bug 1348273 but it's impossible to do so. IIUC those annotations were added specifically to debug the crash references in that bug, but why were annotations used instead of crash notes? AppendAppNotesToCrashReport() can be used to append any kind of free-form data to a crash report could it be used instead? The way I see it, crash annotations are not a good fit for bug 1399557 because if you hit the same error more than once you will get only the last failure recorded. That's because AnnotateCrashReport() will overwrite the content of previous calls with the same key. AppendAppNotesToCrashReport() doesn't suffer from this problem as it will keep appending further notes to the crash dump.

Comment 2

[(No longer employed by Mozilla) Aaron Klotz]

Makes sense. I have no objection to using App Notes instead.

Comment 3

[Gabriele Svelto [:gsvelto]]

Thanks, I'll convert the annotation then.

Comment 4

[Gabriele Svelto [:gsvelto]]

Attachment: Bug 1434944 - Use application notes for debugging crashes related to bug 1399557;

Review commit: https://reviewboard.mozilla.org/r/218694/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/218694/

Comment 5

[(No longer employed by Mozilla) Aaron Klotz]

Comment on attachment 8949310 [details]
Bug 1434944 - Use application notes for debugging crashes related to bug 1399557;

https://reviewboard.mozilla.org/r/218694/#review225304

Thanks!

Comment 6

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s ef9c5017c30f90177025beccda02622b40654ce7 -d d9317a029044: rebasing 446976:ef9c5017c30f "Bug 1434944 - Use application notes for debugging crashes related to bug 1399557; r=aklotz" (tip)
merging ipc/mscom/Interceptor.cpp
warning: conflicts while merging ipc/mscom/Interceptor.cpp! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 7

[Gabriele Svelto [:gsvelto]]

This was rejected because bug 1431404 has already landed removing the annotation altogether, closing this bug too.