Closed Bug 1434946 Opened 6 years ago Closed 6 years ago

MediaEngineRemoteVideoSource getSettings no longer reports constrained framerate

Categories

(Core :: WebRTC: Audio/Video, defect, P2)

58 Branch
defect

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox-esr52 --- unaffected
firefox58 --- unaffected
firefox59 --- unaffected
firefox60 --- fixed

People

(Reporter: pehrsons, Assigned: pehrsons)

References

Details

(Keywords: regression)

Attachments

(3 files)

A couple of js-observable regressions related to MediaStreamTrack::GetSettings() fell out of bug 1299515 and the work to make MediaEngineRemoteVideoSource non-sharable.

Notably we no longer set the framerate property.
P2 for being a regression, but rank 19 for being low-prio.
Rank: 19
Keywords: regression
Priority: -- → P2
See Also: → 1436104
Comment on attachment 8947740 [details]
Bug 1434946 - Report resolution change in settings already on first frame.

https://reviewboard.mozilla.org/r/217452/#review224064
Comment on attachment 8947741 [details]
Bug 1434946 - Set framerate in settings when capabilities are updated.

https://reviewboard.mozilla.org/r/217454/#review224066
Attachment #8947741 - Flags: review?(jib) → review+
Comment on attachment 8947740 [details]
Bug 1434946 - Report resolution change in settings already on first frame.

https://reviewboard.mozilla.org/r/217452/#review224068
Attachment #8947740 - Flags: review?(jib) → review+
Pushed by pehrsons@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/c6e90b3e141f
Report resolution change in settings already on first frame. r=jib
https://hg.mozilla.org/integration/autoland/rev/cf134b262f6a
Set framerate in settings when capabilities are updated. r=jib
https://hg.mozilla.org/integration/autoland/rev/210eba4219fa
Indentation fix. r=jib
Depends on: 1450954
Depends on: 1454625
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: