1434958 - Allow using gstreamer 1.0 and don't hardcode paths when setting up fake devices for webrtc testing

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, enhancement, P2)

Comment 1

[Paul Adenot (:padenot)]

Attachment: Bug 1434958 - Allow using gstreamer 1.0 and don't hardcode paths when setting up fake devices for webrtc testing.

Review commit: https://reviewboard.mozilla.org/r/217230/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/217230/

Comment 2

[Andreas Pehrson [:pehrsons] (PTO; back in Aug)]

Comment on attachment 8947520 [details]
Bug 1434958 - Allow using gstreamer 1.0 and don't hardcode paths when setting up fake devices for webrtc testing.

https://reviewboard.mozilla.org/r/217230/#review223012

::: testing/mochitest/mochitest_options.py:814
(Diff revision 1)
> -                    parser.error(
> +                parser.error(
> -                        'Missing binary %s required for '
> +                    'Missing binary %s required for '
> -                        '--use-test-media-devices' % f)
> +                    '--use-test-media-devices' % f)

This needs to be fixed so it prints the executable we couldn't find.

Comment 3

[Paul Adenot (:padenot)]

Comment on attachment 8947520 [details]
Bug 1434958 - Allow using gstreamer 1.0 and don't hardcode paths when setting up fake devices for webrtc testing.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/217230/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b0abc87c721e
Allow using gstreamer 1.0 and don't hardcode paths when setting up fake devices for webrtc testing. r=pehrsons

Comment 5

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/b0abc87c721e