Closed Bug 1434958 Opened 6 years ago Closed 6 years ago

Allow using gstreamer 1.0 and don't hardcode paths when setting up fake devices for webrtc testing

Categories

(Core :: WebRTC: Audio/Video, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: padenot, Assigned: padenot)

Details

Attachments

(1 file)

      No description provided.
Assignee: nobody → padenot
Rank: 15
Priority: -- → P2
Comment on attachment 8947520 [details]
Bug 1434958 - Allow using gstreamer 1.0 and don't hardcode paths when setting up fake devices for webrtc testing.

https://reviewboard.mozilla.org/r/217230/#review223012

::: testing/mochitest/mochitest_options.py:814
(Diff revision 1)
> -                    parser.error(
> +                parser.error(
> -                        'Missing binary %s required for '
> +                    'Missing binary %s required for '
> -                        '--use-test-media-devices' % f)
> +                    '--use-test-media-devices' % f)

This needs to be fixed so it prints the executable we couldn't find.
Attachment #8947520 - Flags: review?(apehrson) → review+
Pushed by paul@paul.cx:
https://hg.mozilla.org/integration/autoland/rev/b0abc87c721e
Allow using gstreamer 1.0 and don't hardcode paths when setting up fake devices for webrtc testing. r=pehrsons
https://hg.mozilla.org/mozilla-central/rev/b0abc87c721e
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: