1434963 - Apply CORS Mode to shape-outside ImageValues at point of construction

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P2)

Description

[Brad Werth [:bradwerth]]

Bug 1418930 adds a method of CORS mode setting for shape-outside images that mutates the style structs at display time. The CORS mode setting should be done earlier, when the ImageValues are constructed. This requires larger changes to ImageValue constructors and also to the Stylo methods that call them.

Gecko code sites that need changes:
ImageValue constructors
nsRuleNode::ComputeDisplayData
nsStyleStruct::FinishStyle (remove the method used in Bug 1418930)

Stylo code sites that need changes:
Gecko_ImageValue_Create
basic_shape::parse
ImageOrUrl::parse
build_image_value

https://bugzilla.mozilla.org/show_bug.cgi?id=1418930#c42

Comment 1

[Jet Villegas (inactive)]

[ Triage 2017/02/20: P2 ]

Comment 2

[Brad Werth [:bradwerth]]

Attachment: Bug 1434963 Part 1: Change Gecko_ImageValue_Create to take a CORS mode argument.

Comment 3

[Brad Werth [:bradwerth]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=808912c64cf3681fc979aec9a115bec8e962a56b

Comment 4

[Brad Werth [:bradwerth]]

Attachment: Bug 1434963 Part 2: Expand the Parser trait to allow anonymous CORS to be applied.

Depends on D5106

Comment 5

[Brad Werth [:bradwerth]]

Attachment: Bug 1434963 Part 3: Remove style struct mutation in nsStyleDisplay::FinishStyle.

Depends on D5341

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9006764 [details]
Bug 1434963 Part 1: Change Gecko_ImageValue_Create to take a CORS mode argument.

Emilio Cobos Álvarez (:emilio) has approved the revision.

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9007399 [details]
Bug 1434963 Part 3: Remove style struct mutation in nsStyleDisplay::FinishStyle.

Emilio Cobos Álvarez (:emilio) has approved the revision.

Comment 8

[Brad Werth [:bradwerth]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d4739656f6c291493fd47df5bf69cb360b77df88

Comment 9

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9007397 [details]
Bug 1434963 Part 2: Expand the Parser trait to allow anonymous CORS to be applied.

Emilio Cobos Álvarez (:emilio) has approved the revision.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/57eda20ed463
Part 1: Change Gecko_ImageValue_Create to take a CORS mode argument. r=emilio
https://hg.mozilla.org/integration/autoland/rev/768de4eb3d45
Part 2: Expand the Parser trait to allow anonymous CORS to be applied. r=emilio
https://hg.mozilla.org/integration/autoland/rev/d5b6fd5ab512
Part 3: Remove style struct mutation in nsStyleDisplay::FinishStyle. r=emilio

Comment 11

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/57eda20ed463
https://hg.mozilla.org/mozilla-central/rev/768de4eb3d45
https://hg.mozilla.org/mozilla-central/rev/d5b6fd5ab512

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Please request Beta on these. They graft cleanly as-landed. Also, please provide rebased patches for ESR60 and request approval on those when ready.

Comment 13

[Brad Werth [:bradwerth]]

Comment on attachment 9006764 [details]
Bug 1434963 Part 1: Change Gecko_ImageValue_Create to take a CORS mode argument.

Approval Request Comment
[Feature/Bug causing the regression]: 1418930
[User impact if declined]: Other needed CORS mode fixes require this.
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: parts 2 and 3 of this bug.
[Is the change risky?]: no
[Why is the change risky/not risky?]: no behavior change associated with it
[String changes made/needed]: none

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9006764 [details]
Bug 1434963 Part 1: Change Gecko_ImageValue_Create to take a CORS mode argument.

Approved for 63.0b10.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/25c09c7aa7cb
https://hg.mozilla.org/releases/mozilla-beta/rev/b06282a810e5
https://hg.mozilla.org/releases/mozilla-beta/rev/1c22f27d31ec

Comment 16

[Brad Werth [:bradwerth]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=618440d778779d69216f85f04ed6fb7574391c59

Comment 17

[Brad Werth [:bradwerth]]

Attachment: esr60-cors1.patch

[Approval Request Comment]
If this is not a sec:{high,crit} bug, please state case for ESR consideration: This part, and parts 2 and 3 to follow are blockers for security bug 1418470.
User impact if declined: Security bug 1418470 won't land.
Fix Landed on Version: 63
Risk to taking this patch (and alternatives if risky): Low risk. This makes no change to web behavior.
String or UUID changes made by this patch: none

See https://wiki.mozilla.org/Release_Management/ESR_Landing_Process for more info.

Comment 18

[Brad Werth [:bradwerth]]

Attachment: esr60-cors2.patch

Comment 19

[Brad Werth [:bradwerth]]

Attachment: esr60-cors3.patch

Comment 20

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9012431 [details] [diff] [review]
esr60-cors1.patch

Needed for bug 1418470, approved for ESR 60.3.

Comment 21

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr60/rev/1e6dad87efed
https://hg.mozilla.org/releases/mozilla-esr60/rev/6558c46df9ea
https://hg.mozilla.org/releases/mozilla-esr60/rev/686fcfa8abd6