1434968 - mSavedStreamedSamples and mSavedStreamedMarkers are kept alive even after the profiler is stopped

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect)

Description

[Markus Stange [:mstange]]

mSavedStreamedSamples and mSavedStreamedMarkers are really something that should only exist during a single run of the profiler. But they're stored on ThreadInfo, which exists throughout the thread's lifetime, even if the profiler is not running. And there is no code that manually clears these strings when the profiler is stopped, as far as I can tell.

Comment 1

[Markus Stange [:mstange]]

Attachment: Bug 1434968 - Clear mUniqueStacks, mSavedStreamedSamples and mSavedStreamedMarkers when the profiler is stopped.

Review commit: https://reviewboard.mozilla.org/r/218220/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/218220/

Comment 2

[Nicholas Nethercote [inactive]]

Comment on attachment 8948843 [details]
Bug 1434968 - Clear mUniqueStacks, mSavedStreamedSamples and mSavedStreamedMarkers when the profiler is stopped.

https://reviewboard.mozilla.org/r/218220/#review224042

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ad00751ceb1b
Clear mUniqueStacks, mSavedStreamedSamples and mSavedStreamedMarkers when the profiler is stopped. r=njn

Comment 4

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/ad00751ceb1b