1434980 - New XCUITest: Drag and Drop tests

Status: RESOLVED FIXED

(Firefox for iOS :: Build & Test, enhancement)

Description

[Isabel Rios[:isabel_rios]]

Drag and drop is a new feature implemented in v11.x. There are no XCUITests covering it yet. So far it will only work on iPad.
There would be some scenarios could be covered:
- Rearrange tabs by dragging and dropping
- Drag link into text boxes
- Drag link into the address bar
-....

Comment 1

[Isabel Rios[:isabel_rios]]

Attachment: Pull Request

Comment 2

[Isabel Rios[:isabel_rios]]

This feature is part of v11.x branch. Adding [needsuplift] so that we do not forget to uplift this set of test cases to check the feature in that branch too.

Comment 3

[No-Jun Park [:njpark]]

Comment on attachment 8948368 [details] [review]
Pull Request

added a suggestion to use a method with parameter to reduce the code duplication, but it's up to you. Looks good.

Comment 4

[Isabel Rios[:isabel_rios]]

All improvements that could help the test to be more readable and that avoid code duplication are welcome! will try to implement that method. Thanks!

Comment 5

[Isabel Rios[:isabel_rios]]

In addition to your suggestion I created another method for dragAndDrop and added two tests covering new features that just landed. Could you please take another look to the new implementation? Thanks!

Comment 6

[No-Jun Park [:njpark]]

Yup looks good to me!

Comment 7

[Isabel Rios[:isabel_rios]]

Merged master: https://github.com/mozilla-mobile/firefox-ios/commit/ed5b9ca23a3d08a9b192b05fc952995a4399990d

Comment 8

[Isabel Rios[:isabel_rios]]

Uplifted v11.x: https://github.com/mozilla-mobile/firefox-ios/commit/7dacb4317378380b8cb04a00428c18053c428abd