1434981 - Show used fonts for text nodes too

Status: RESOLVED FIXED

(DevTools :: Inspector, enhancement, P3)

Description

[Patrick Brosset <:pbro>]

There's no reason to only be showing fonts for element nodes. We can also do it for text nodes, and in fact it's very useful because in that case it doesn't go into sub children nodes and get their fonts too.

Comment 1

[Patrick Brosset <:pbro>]

Attachment: Bug 1434981 - Display fonts for text nodes too;

Review commit: https://reviewboard.mozilla.org/r/217240/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/217240/

Comment 2

[Patrick Brosset <:pbro>]

Comment on attachment 8947541 [details]
Bug 1434981 - Display fonts for text nodes too;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/217240/diff/1-2/

Comment 3

[Patrick Brosset <:pbro>]

Comment on attachment 8947541 [details]
Bug 1434981 - Display fonts for text nodes too;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/217240/diff/2-3/

Comment 4

[Patrick Brosset <:pbro>]

Pushed to try, discovered an issue on linux because Arial doesn't exist there: https://treeherder.mozilla.org/#/jobs?repo=try&revision=03ac12e12bd5ee9a5fb2ec0a3b25088c5e0101ad&group_state=expanded&selectedJob=159908482

Comment 5

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8947541 [details]
Bug 1434981 - Display fonts for text nodes too;

https://reviewboard.mozilla.org/r/217240/#review223096

::: devtools/client/inspector/fonts/test/browser_fontinspector_text-node.js:4
(Diff revision 3)
> +/* vim: set ts=2 et sw=2 tw=80: */
> +/* Any copyright is dedicated to the Public Domain.
> +   http://creativecommons.org/publicdomain/zero/1.0/ */
> +"use strict";

Add a new line before "use strict";

Comment 6

[Patrick Brosset <:pbro>]

Comment on attachment 8947541 [details]
Bug 1434981 - Display fonts for text nodes too;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/217240/diff/3-4/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/83725aa063c5
Display fonts for text nodes too; r=gl

Comment 8

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/83725aa063c5