Replace clients.js own commands queue with AsyncQueueCaller

RESOLVED FIXED in Firefox 62

Status

()

enhancement
P3
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: eoger, Assigned: cng)

Tracking

unspecified
Firefox 62
Points:
---

Firefox Tracking Flags

(firefox62 fixed)

Details

Attachments

(1 attachment)

Reporter

Description

a year ago
We should replace our homemade queue system [0] with AsyncQueueCaller that we introduced in bug 633062.

[0] https://searchfox.org/mozilla-central/source/services/sync/modules/engines/clients.js#286
Priority: -- → P3
Comment hidden (mozreview-request)
Reporter

Comment 2

a year ago
mozreview-review
Comment on attachment 8981583 [details]
Bug 1435000 - Refactor client engine queue to use AsyncQueueCaller

https://reviewboard.mozilla.org/r/247684/#review253698

r+ with fix, thank you!

::: services/sync/modules/engines/clients.js:89
(Diff revision 1)
>  
>  function ClientEngine(service) {
>    SyncEngine.call(this, "Clients", service);
>  
>    this.fxAccounts = fxAccounts;
> -  this.addClientCommandQueue = Promise.resolve();
> +  this.addClientCommandQueue = Async.asyncQueueCaller(this._trackerObj._log);

How about we use the superclass _log instead https://searchfox.org/mozilla-central/source/services/sync/modules/engines.js#703 ?
Reporter

Comment 3

a year ago
mozreview-review
Comment on attachment 8981583 [details]
Bug 1435000 - Refactor client engine queue to use AsyncQueueCaller

https://reviewboard.mozilla.org/r/247684/#review253700
Attachment #8981583 - Flags: review?(eoger) → review+
Comment hidden (mozreview-request)

Comment 5

a year ago
Pushed by eoger@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/57b10eb3ea6f
Refactor client engine queue to use AsyncQueueCaller r=eoger

Comment 6

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/57b10eb3ea6f
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 62
Assignee: nobody → cng
You need to log in before you can comment on or make changes to this bug.