1435000 - Replace clients.js own commands queue with AsyncQueueCaller

Status: RESOLVED FIXED

(Firefox :: Sync, enhancement, P3)

Description

[Edouard Oger [:eoger]]

We should replace our homemade queue system [0] with AsyncQueueCaller that we introduced in bug 633062.

[0] https://searchfox.org/mozilla-central/source/services/sync/modules/engines/clients.js#286

Comment 1

[Carol Ng [:cng]]

Attachment: Bug 1435000 - Refactor client engine queue to use AsyncQueueCaller

Review commit: https://reviewboard.mozilla.org/r/247684/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/247684/

Comment 2

[Edouard Oger [:eoger]]

Comment on attachment 8981583 [details]
Bug 1435000 - Refactor client engine queue to use AsyncQueueCaller

https://reviewboard.mozilla.org/r/247684/#review253698

r+ with fix, thank you!

::: services/sync/modules/engines/clients.js:89
(Diff revision 1)
>  
>  function ClientEngine(service) {
>    SyncEngine.call(this, "Clients", service);
>  
>    this.fxAccounts = fxAccounts;
> -  this.addClientCommandQueue = Promise.resolve();
> +  this.addClientCommandQueue = Async.asyncQueueCaller(this._trackerObj._log);

How about we use the superclass _log instead https://searchfox.org/mozilla-central/source/services/sync/modules/engines.js#703 ?

Comment 3

[Edouard Oger [:eoger]]

Comment on attachment 8981583 [details]
Bug 1435000 - Refactor client engine queue to use AsyncQueueCaller

https://reviewboard.mozilla.org/r/247684/#review253700

Comment 4

[Carol Ng [:cng]]

Comment on attachment 8981583 [details]
Bug 1435000 - Refactor client engine queue to use AsyncQueueCaller

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/247684/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/57b10eb3ea6f
Refactor client engine queue to use AsyncQueueCaller r=eoger

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/57b10eb3ea6f