Closed
Bug 1435000
Opened 3 years ago
Closed 3 years ago
Replace clients.js own commands queue with AsyncQueueCaller
Categories
(Firefox :: Sync, enhancement, P3)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
Firefox 62
Tracking | Status | |
---|---|---|
firefox62 | --- | fixed |
People
(Reporter: eoger, Assigned: cng)
Details
Attachments
(1 file)
We should replace our homemade queue system [0] with AsyncQueueCaller that we introduced in bug 633062. [0] https://searchfox.org/mozilla-central/source/services/sync/modules/engines/clients.js#286
Updated•3 years ago
|
Priority: -- → P3
Comment hidden (mozreview-request) |
Reporter | ||
Comment 2•3 years ago
|
||
mozreview-review |
Comment on attachment 8981583 [details] Bug 1435000 - Refactor client engine queue to use AsyncQueueCaller https://reviewboard.mozilla.org/r/247684/#review253698 r+ with fix, thank you! ::: services/sync/modules/engines/clients.js:89 (Diff revision 1) > > function ClientEngine(service) { > SyncEngine.call(this, "Clients", service); > > this.fxAccounts = fxAccounts; > - this.addClientCommandQueue = Promise.resolve(); > + this.addClientCommandQueue = Async.asyncQueueCaller(this._trackerObj._log); How about we use the superclass _log instead https://searchfox.org/mozilla-central/source/services/sync/modules/engines.js#703 ?
Reporter | ||
Comment 3•3 years ago
|
||
mozreview-review |
Comment on attachment 8981583 [details] Bug 1435000 - Refactor client engine queue to use AsyncQueueCaller https://reviewboard.mozilla.org/r/247684/#review253700
Attachment #8981583 -
Flags: review?(eoger) → review+
Comment hidden (mozreview-request) |
Pushed by eoger@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/57b10eb3ea6f Refactor client engine queue to use AsyncQueueCaller r=eoger
Comment 6•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/57b10eb3ea6f
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 62
Updated•3 years ago
|
Assignee: nobody → cng
You need to log in
before you can comment on or make changes to this bug.
Description
•