1435148 - --enable-address-sanitizer should --disable-jemalloc

Status: REOPENED

(Firefox Build System :: General, enhancement)

Description

[Jeff Walden [:Waldo]]

I tried doing a JS engine build using --enable-address-sanitizer (plus a few other command line options/envvars) and got a complete build.  Running it immediately crashed in some sort of jemalloc-related goo, tho.  glandium says we should change the build system so asking for ASAN, disables jemalloc, rather than requiring a --disable-jemalloc be manually provided in that instance.

Comment 1

[Jesse Schwartzentruber (:truber)]

Attachment: Bug 1435148 - Disable jemalloc when any sanitizer is used. r?glandium!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d52d4b62a347
Disable jemalloc when any sanitizer is used. r=glandium

Comment 3

[Oana Pop-Rus]

Backed out changeset d52d4b62a347 (bug 1435148) for python tier2 failures in test_moz_configure.py

Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=superseded%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&revision=d52d4b62a347971853dbcdf3dfc4d62a12a2a3b4&selectedJob=296835613

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=296835613&repo=autoland&lineNumber=836

Backout: https://hg.mozilla.org/integration/autoland/rev/4343fd117c0dc64fa66e225e77cd75e2b3a4736a

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/823857306bce
Disable jemalloc when any sanitizer is used. r=glandium

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/823857306bce

Comment 6

[Stefan Hindli [:stefan_hindli]]

Backed this out from autoland for causing Bug 1631468 as per glandium's request on riot.

Comment 7

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4e5ba6693986
Backed out changeset 823857306bce for causing bug 1631468 CLOSED TREE

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backout merged: https://hg.mozilla.org/mozilla-central/rev/4e5ba6693986

Comment 9

[BugBot [:suhaib / :marco]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:truber, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Comment 10

[Jesse Schwartzentruber (:truber)]

I rebased this and it still causes the same python test failures. Leaving open in case we ever tackle this.