Verify defaults in all.js prefs.

VERIFIED INVALID

Status

SeaMonkey
Preferences
P3
normal
VERIFIED INVALID
19 years ago
14 years ago

People

(Reporter: Gagan, Unassigned)

Tracking

({helpwanted})

Trunk
All
Linux
helpwanted

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [nsbeta3-])

(Reporter)

Description

19 years ago
GetIntPref sets the value to zero and returns NS_OK for missing prefs. BAD BAD
BAD

Comment 1

19 years ago
Gagan, can you clarify what "missing prefs" mean? Does it mean the itself not
being found in the prefs.js file or is the pref missing from the default pref
files like all.js?
(Reporter)

Comment 2

19 years ago
missing from prefs.js.

Comment 3

19 years ago
If, a pref is missing from prefs.js, then the libpref code looks if the pref has
a default value and then returns the default value. In the case of

 rv = prefs->GetIntPref("network.proxy.http_port",&proxyPort); in
nsHTTPHandler.cpp, if "network.proxy.http_port" is not specified in prefs.js, it
is returning the default value of the pref i.e. 0, which is specified in all.js
pref("network.proxy.http_port",             0);
and returns NS_OK.
(Reporter)

Comment 4

19 years ago
then we should remove that from all.js. There should not be any default value
for http proxy port.

Updated

19 years ago
Status: NEW → RESOLVED
Last Resolved: 19 years ago
Resolution: --- → INVALID

Comment 5

19 years ago
There are some network.proxy..... prefs in all.js. Maybe, you or someone in
necko should check if these have the correct default values, or whether they
should have a default value, if at all.

Marking, this bug as invalid.
(Reporter)

Updated

19 years ago
Status: RESOLVED → REOPENED
Summary: GetIntPref incorrectly returns NS_OK for missing prefs. → Verify defaults in all.js prefs.
(Reporter)

Comment 6

19 years ago
Neeti this needs to remain open till default prefs in all.js are cleared by
their owners. I have updated the summary.

Updated

19 years ago
Resolution: INVALID → ---

Comment 7

19 years ago
Clearing Invalid resolution due to reopen.

Updated

19 years ago
Target Milestone: M15

Updated

19 years ago
Status: REOPENED → ASSIGNED
spam: added self to cc list as this might affect my realm.

Comment 9

19 years ago
Moving all libPref component bugs to new Preferences: Backend component.  
libPref component will be deleted.
Component: libPref → Preferences: Backend

Updated

18 years ago
Target Milestone: M15 → M16

Updated

18 years ago
Target Milestone: M16 → M17

Comment 10

18 years ago
spam: moving qa contact on some bugs from paulmac to sairuh@netscape.com
QA Contact: paulmac → sairuh

Updated

18 years ago
Target Milestone: M17 → M18
(Reporter)

Comment 11

18 years ago
prefs to mcafee
Assignee: neeti → locka
Status: ASSIGNED → NEW
Component: Preferences: Backend → ActiveX Wrapper
QA Contact: sairuh → cpratt
Target Milestone: M18 → ---
(Reporter)

Comment 12

18 years ago
prefs to mcafee
Assignee: locka → neeti
Component: ActiveX Wrapper → Preferences: Backend
QA Contact: cpratt → sairuh
(Reporter)

Comment 13

18 years ago
argh... didn't work the last time. pardon the spam. ->mcafee
Assignee: neeti → mcafee
Component: Preferences: Backend → Preferences

Comment 14

18 years ago
dveditz
Assignee: mcafee → dveditz

Comment 15

18 years ago
this is a stale bug. it has not been touched in 30 days. it is still the same.
some of the of the applications that are missing in the pref menue is in
apprearance.the show tool bar as.. is missin and the cookie option is missing also
i know it's rather late to nominate for beta3, but, what the hell. cc'ing qa 
folk who're also checking out backend prefs from an automation stance (if even 
feasible).
Keywords: helpwanted, nsbeta3
I have no clue what pref defaults should or shouldn't be.. that's really up to 
the folks responsible for their module.
Assignee: dveditz → nobody
Whiteboard: [nsbeta3-]
Hardware: PC → All

Comment 18

17 years ago
I don't think this bug is currently useful to anyone...
Status: NEW → RESOLVED
Last Resolved: 19 years ago17 years ago
Resolution: --- → INVALID
*shrug* okidoke.
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.