14352 - Verify defaults in all.js prefs.

Status: VERIFIED INVALID

(SeaMonkey :: Preferences, defect, P3)

Description

[Gagan]

GetIntPref sets the value to zero and returns NS_OK for missing prefs. BAD BAD
BAD

Comment 1

[neeti]

Gagan, can you clarify what "missing prefs" mean? Does it mean the itself not
being found in the prefs.js file or is the pref missing from the default pref
files like all.js?

Comment 2

[Gagan]

missing from prefs.js.

Comment 3

[neeti]

If, a pref is missing from prefs.js, then the libpref code looks if the pref has
a default value and then returns the default value. In the case of

 rv = prefs->GetIntPref("network.proxy.http_port",&proxyPort); in
nsHTTPHandler.cpp, if "network.proxy.http_port" is not specified in prefs.js, it
is returning the default value of the pref i.e. 0, which is specified in all.js
pref("network.proxy.http_port",             0);
and returns NS_OK.

Comment 4

[Gagan]

then we should remove that from all.js. There should not be any default value
for http proxy port.

Comment 5

[neeti]

There are some network.proxy..... prefs in all.js. Maybe, you or someone in
necko should check if these have the correct default values, or whether they
should have a default value, if at all.

Marking, this bug as invalid.

Comment 6

[Gagan]

Neeti this needs to remain open till default prefs in all.js are cleared by
their owners. I have updated the summary.

Comment 7

[leger]

Clearing Invalid resolution due to reopen.

Comment 8

[sairuh (rarely reading bugmail)]

spam: added self to cc list as this might affect my realm.

Comment 9

[leger]

Moving all libPref component bugs to new Preferences: Backend component.  
libPref component will be deleted.

Comment 10

[Paul MacQuiddy]

spam: moving qa contact on some bugs from paulmac to [e-mail]

Comment 11

[Gagan]

prefs to mcafee

Comment 12

[Gagan]

prefs to mcafee

Comment 13

[Gagan]

argh... didn't work the last time. pardon the spam. ->mcafee

Comment 14

[Chris McAfee]

dveditz

Comment 15

[kenneth buttler]

this is a stale bug. it has not been touched in 30 days. it is still the same.
some of the of the applications that are missing in the pref menue is in
apprearance.the show tool bar as.. is missin and the cookie option is missing also

Comment 16

[sairuh (rarely reading bugmail)]

i know it's rather late to nominate for beta3, but, what the hell. cc'ing qa 
folk who're also checking out backend prefs from an automation stance (if even 
feasible).

Comment 17

[Daniel Veditz [:dveditz]]

I have no clue what pref defaults should or shouldn't be.. that's really up to 
the folks responsible for their module.

Comment 18

[Blake Ross]

I don't think this bug is currently useful to anyone...

Comment 19

[sairuh (rarely reading bugmail)]

*shrug* okidoke.